Skip to content

Raise minimum numpy version to 1.23.5 to fix installation errors on windows #6082

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 14, 2024
Merged

Raise minimum numpy version to 1.23.5 to fix installation errors on windows #6082

merged 1 commit into from
Mar 14, 2024

Conversation

alex-mccarthy-unity
Copy link
Contributor

@alex-mccarthy-unity alex-mccarthy-unity commented Mar 13, 2024 •
edited
Loading

Proposed change(s)

Fixes the following errors when installing ml-agents-envs on windows if numpy 1.21.2 is already installed:

  Building wheel for numpy (pyproject.toml) ... error
  error: subprocess-exited-with-error

  × Building wheel for numpy (pyproject.toml) did not run successfully.
  │ exit code: 1
  ╰─> [326 lines of output]
      setup.py:63: RuntimeWarning: NumPy 1.21.2 may not yet support Python 3.10.
        warnings.warn(
      Running from numpy source directory.

Useful links (Github issues, JIRA tickets, ML-Agents forum threads etc.)

Fixes #6047

Types of change(s)

  • Bug fix
  • New feature
  • Code refactor
  • Breaking change
  • Documentation update
  • Other (please describe) dependency upgrade

Checklist

  • Added tests that prove my fix is effective or that my feature works
  • Updated the changelog (if applicable)
  • Updated the documentation (if applicable)
  • Updated the migration guide (if applicable)

Other comments

@alex-mccarthy-unity
Raise minimum numpy version to 1.23.5 to fix installation errors on w…
998bc9b 
…indows

Fixes #6047

Fixes the following errors when installing ml-agents-envs on windows if numpy 1.21.2 is already installed:
```
  Building wheel for numpy (pyproject.toml) ... error
  error: subprocess-exited-with-error

  × Building wheel for numpy (pyproject.toml) did not run successfully.
  │ exit code: 1
  ╰─> [326 lines of output]
      setup.py:63: RuntimeWarning: NumPy 1.21.2 may not yet support Python 3.10.
        warnings.warn(
      Running from numpy source directory.
```
@alex-mccarthy-unity alex-mccarthy-unity changed the title Raise minimum numpy version to 1.23.5 to fix installation errors on w… Raise minimum numpy version to 1.23.5 to fix installation errors on windows Mar 13, 2024
@alex-mccarthy-unity alex-mccarthy-unity mentioned this pull request Mar 13, 2024
Closed
10 tasks
miguelalonsojr
miguelalonsojr approved these changes Mar 13, 2024
View reviewed changes
Copy link
Collaborator

@miguelalonsojr miguelalonsojr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@alex-mccarthy-unity alex-mccarthy-unity merged commit b2a6b5b into develop Mar 14, 2024
9 checks passed
@delete-merged-branch delete-merged-branch bot deleted the re-fix-numpy-version branch March 14, 2024 05:56
This was referenced Mar 14, 2024
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@miguelalonsojr miguelalonsojr miguelalonsojr approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

release-21-branch numpy can't install successful.
2 participants
@alex-mccarthy-unity @miguelalonsojr