Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

directionalfellingsuccessdef in treefelling.R #35

Open
5 tasks done
VincyaneBadouard opened this issue Aug 4, 2021 · 2 comments
Open
5 tasks done

directionalfellingsuccessdef in treefelling.R #35

VincyaneBadouard opened this issue Aug 4, 2021 · 2 comments
Labels
dev

Comments

@VincyaneBadouard
Copy link
Owner

VincyaneBadouard commented Aug 4, 2021 •
edited by GeraldineDerroire
Loading

  • code
  • test
  • document (V0)
  • Sylvain's check (code)
  • Geraldine check (doc)
@sylvainschmitt
Copy link
Collaborator

sylvainschmitt commented Aug 4, 2021 •
edited
Loading

Everything is great, at the exception of the naming perhaps, congrats !

  • Bad naming, what about isdirectedfall, the answer being a boolean as your column is
  • Beware french comments in code

VincyaneBadouard pushed a commit that referenced this issue Aug 6, 2021
#14 #35 #36
57a07e4
@sylvainschmitt
Copy link
Collaborator

@VincyaneBadouard , I'm considering it as code checked as the naming and the comments are not code

@VincyaneBadouard VincyaneBadouard changed the title successfail in treefelling.R directionalfellingsuccessdef in treefelling.R Aug 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
dev
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@sylvainschmitt @VincyaneBadouard