Update router_state.ts #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@mmalerba Thanks for merging my other two suggestions angular/components#30324 and angular/components#30477 for optional typing. |
|
It looks like this PR is to your own fork, I assume you meant to send it to angular/angular? |
|
Yes, I guess I did that wrong. |
Add optional typing to ActivatedRoute and ActivatedRouteSnapshot data to enforce strict route data typing. Closes angular#30477
|
See here for a PR against the correct repository: angular#60064 Thanks again! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It should be possible to explicitly type route data.
This PR allows for optional typing of ActivatedRoute and ActivatedRouteSnapshot.
Fallback to the original "Data" type for backwards compatibility.