-
Notifications
You must be signed in to change notification settings - Fork 26
Fix: Add compatibility with Woo HPOS. Allow order fields. #127
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Could you add a few testing instructions? I'd like to be sure I'm understanding what you're seeing and aiming to fix. |
I updated the description to include a small testing instructions. Also, I will finish today some e2e tests to include all test cases. |
I will make another review after some rest time. The PR is ready, but still needs a double check to remove maybe not needed "AI" generated stuff on e2e tests, any wrong "since", or any duplicated or wrong comment due to duplicating files for tests. |
I forgot to push the last e2e. Now is ready. |
3b1d9cd
to
fbaf52f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since one of the latest commits, class initialization fails: the classes are trying to be loaded from includes/SCF/
folder, because of the namespace and autoloader configuration, instead of includes/Meta
.
Did you do a |
I hadn't before, but this didn't help, even though the autoloader setting seems correct. |
You are right, I removed the SCF Meta on the composer file 🤦♂️ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Everything works now as expected, @cbravobernal and I have been testing it for the last couple of hours.
What
With the last release of WooCommerce, a HPOS was introduced..
SCF needs some updates to be compatible with these new meta data management. One first bug that appeared is that if any user adds Order fields, these are not shown or updated in the order page. This PR fixes that.
How to test
You need a Woo (v 9.8.4) installed, at least one product and an order.
How to test the meta optimization.
These checks are already included in this PR as e2e tests. But feel free to test them manually.