Fix erroneous encoding via contextual serialization #274
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue:
In bigger structures, when the specific class was known, kotlinx.serialization would pick the generic polymorphic serializer for
InputDescriptor
instead of the specificInputDescriptorSerializer
which is defined for the interface. In this case thetype
discriminator was added.Solution:
To address this we force the serializer to use the contextual serializer instead which we set to the appropriate
InputDescriptorSerializer
.To this end we also add a
BaseInputDescriptorSerializer
which only calls theDifInputDescriptor
serializer without adding the type discriminator.We need contextual serialization because
InputDescriptor
as an interface allows for open polymorphism and in our use case specificallyQesInputDescriptor
is not defined in the DIF artifact which means the Serializer cannot be hard-coded into thePresentationDefintion
class.Also added some tests.