Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SDK-3736] Make MessageFilter subscription filtering tree-shakable #1473

Merged
merged 2 commits into from
Nov 21, 2023
Merged

[SDK-3736] Make MessageFilter subscription filtering tree-shakable #1473

merged 2 commits into from
Nov 21, 2023

Conversation

lawrence-forooghian
Copy link
Collaborator

We expose a tree-shakable MessageIteractions module which allows users to pass a MessageFilter object to RealtimeChannel’s subscribe and unsubscribe.

Resolves #1397.

@github-actions github-actions bot temporarily deployed to staging/pull/1473/features October 30, 2023 13:24 Inactive
@github-actions github-actions bot temporarily deployed to staging/pull/1473/bundle-report October 30, 2023 13:25 Inactive
@github-actions github-actions bot temporarily deployed to staging/pull/1473/typedoc October 30, 2023 13:26 Inactive
@lawrence-forooghian lawrence-forooghian marked this pull request as ready for review October 30, 2023 14:38
@lawrence-forooghian lawrence-forooghian mentioned this pull request Oct 31, 2023
Merged
@lawrence-forooghian lawrence-forooghian marked this pull request as draft November 1, 2023 18:33
@lawrence-forooghian lawrence-forooghian force-pushed the 1395-http-tree-shaking branch 2 times, most recently from a7bde37 to 3d3edc0 Compare November 8, 2023 17:50
@lawrence-forooghian lawrence-forooghian force-pushed the 1397-tree-shakable-MessageInteractions branch from 7c379cf to 53cafd4 Compare November 8, 2023 18:01
@github-actions github-actions bot temporarily deployed to staging/pull/1473/features November 8, 2023 18:02 Inactive
@github-actions github-actions bot temporarily deployed to staging/pull/1473/typedoc November 8, 2023 18:02 Inactive
@github-actions github-actions bot temporarily deployed to staging/pull/1473/bundle-report November 8, 2023 18:02 Inactive
@lawrence-forooghian lawrence-forooghian force-pushed the 1397-tree-shakable-MessageInteractions branch from 53cafd4 to 5c54465 Compare November 8, 2023 18:21
@github-actions github-actions bot temporarily deployed to staging/pull/1473/features November 8, 2023 18:22 Inactive
@github-actions github-actions bot temporarily deployed to staging/pull/1473/bundle-report November 8, 2023 18:22 Inactive
@github-actions github-actions bot temporarily deployed to staging/pull/1473/typedoc November 8, 2023 18:23 Inactive
@lawrence-forooghian lawrence-forooghian marked this pull request as ready for review November 9, 2023 13:30
owenpearson
owenpearson approved these changes Nov 14, 2023
View reviewed changes
Copy link
Member

@owenpearson owenpearson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice 👍

@lawrence-forooghian
Extract RealtimeChannel MessageFilter-related code to new class
61cf994 
In preparation for #1397 (making MessageFilter functionality
tree-shakable).
@lawrence-forooghian
Make subscription filtering tree-shakable
6a96472 
We expose a MessageIteractions module which allows users to pass a
MessageFilter object to RealtimeChannel’s `subscribe` and `unsubscribe`.

Resolves #1397.
@lawrence-forooghian lawrence-forooghian force-pushed the 1397-tree-shakable-MessageInteractions branch from 5c54465 to 6a96472 Compare November 14, 2023 18:53
@lawrence-forooghian lawrence-forooghian merged commit 2ff0e5b into 1395-http-tree-shaking Nov 21, 2023
@lawrence-forooghian lawrence-forooghian deleted the 1397-tree-shakable-MessageInteractions branch November 21, 2023 00:12
@lawrence-forooghian lawrence-forooghian mentioned this pull request Nov 21, 2023
Closed
@VeskeR VeskeR mentioned this pull request Mar 1, 2024
Merged
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@owenpearson owenpearson owenpearson approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lawrence-forooghian @owenpearson