Add optional request attribute to Template (#52) #55
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…mplate for issue accordproject#52 Signed-off-by: Chibuezem Marvinrose <rozzeymarvin32@gmail.com>
|
Hi @niallroche Kindly review please. |
|
Changes to the model should be made to protocol.cto and then we can use codegen to create TS files (either from the Concerto model itself using Concerto Codegen or via generation of the OpenAPI and then OpenAPI codegen). https://concerto.accordproject.org/docs/category/code-generation |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added an optional request attribute to org.accordproject.protocol@1.0.0.Template in openapi.json, updated server implementation and documented in specification.md. Successfully tested with a sample request, aligning APAP with CTA files for testing template logic.