tool-cache: Work around a weird GNU Tar behavior on Windows #180
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joshmgross
approved these changes
Oct 24, 2019
eine
approved these changes
Nov 19, 2019
ericsciple
reviewed
Dec 7, 2019
| @@ -200,6 +200,10 @@ export async function extractTar( | |||
| } | |||
|
|
|||
| dest = dest || (await _createExtractFolder(dest)) | |||
| if (IS_WINDOWS) { | |||
| // For some reason, GNU Tar on Windows expects paths to be slash-separated even though this is not the standard Windows path delimiter | |||
| dest = dest.replace(/\\/g, '/') | |||
There was a problem hiding this comment.
I proposed an alternate solution for #165 which will eliminate the need for this.
Let's close on the other PR first before proceeding with this PR.
|
Fixed by #264 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For some reason GNU Tar insists on parsing the destination path using an Unix path delimiter (
/), even on windows where the path delimiter is\.This patch simply rewrites
\to/in the destination path.