Add Zephyr port #10026
Merged
Add Zephyr port #10026
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This port is meant to grow to encompass all existing boards. For now, it is a port while we transition over. It is named `zephyr-cp` to differentiate it from the MicroPython `zephyr` port. They are separate implementations.
dhalbert
approved these changes
Feb 5, 2025
There was a problem hiding this comment.
This is stupendous work! (I started reviewing last night.)
I do not see anything to change. I was wondering about whether some of the commented-code in the networking files could be deleted (some things are implemented), but even if so, that can be done on a later pass.
We can get the stuff in the zephyr-cp README into the Building CircuitPython guide sooner or later.
I did not review all the ruff formatting changes in the inline doc or various .py files, which files were affected makes sense to me.
|
I'm continuing work on the networking stuff so the next PR will replace it all. Thanks for the review! |
jepler
added a commit
to jepler/circuitpython
that referenced
this pull request
Feb 7, 2025
Recently in adafruit#10026 this script was altered so that sometimes items are removed from `boards`. However, this could have side effects. For instance, when a file like `shared/runtime/context_manager_helpers.c` is modified, it doesn't match any per-port or per-board rule so we execute `boards_to_build = all_board_ids`. But if the object `all_board_ids` refers to has been modified by `boards.remove(board)` in an earlier iteration, then we don't end up really building all boards. Noticed during development of adafruit#10040.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This port is meant to grow to encompass all existing boards. For now, it is a port while we transition over.
It is named
zephyr-cpto differentiate it from the MicroPythonzephyrport. They are separate implementations.