web_workflow.c: check for empty SSID before starting web workflow #10103
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the
CIRCUITPY_WIFI_SSID=""
insettings.toml
, the web workflow will get an internal exception when trying to start, and will raise an exception that causes a safe mode, because there is no VM to help raising the exception. I'm assuming this starts a startup-loop, because CIRCUITPY never appears.It is kind of easy to get
CIRCUITPY_WIFI_SSID=""
if you don't give an SSID when using the part of the web installer that adds credentials.Fix is: don't try to start the web workflow if the SSID is empty.
In the long run:
Other internal exceptions might also cause this problem. The question is when to try starting the web workflow. We could prevent repeated failing attempts. We could also not start it when certain safemodes happen.
Tested on a QT PY ESP32-S3 with an empty SSID.