Skip to content

web_workflow.c: check for empty SSID before starting web workflow #10103

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 27, 2025

Conversation

dhalbert
Copy link
Collaborator

If the CIRCUITPY_WIFI_SSID="" in settings.toml, the web workflow will get an internal exception when trying to start, and will raise an exception that causes a safe mode, because there is no VM to help raising the exception. I'm assuming this starts a startup-loop, because CIRCUITPY never appears.

It is kind of easy to get CIRCUITPY_WIFI_SSID="" if you don't give an SSID when using the part of the web installer that adds credentials.

Fix is: don't try to start the web workflow if the SSID is empty.

In the long run:
Other internal exceptions might also cause this problem. The question is when to try starting the web workflow. We could prevent repeated failing attempts. We could also not start it when certain safemodes happen.

Tested on a QT PY ESP32-S3 with an empty SSID.

@dhalbert dhalbert requested review from tannewt and jepler February 26, 2025 18:33
Copy link

@jepler jepler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@dhalbert dhalbert merged commit 2ec0d04 into adafruit:main Feb 27, 2025
251 checks passed
@dhalbert dhalbert deleted the empty-ssid-check-web-workflow branch February 27, 2025 18:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants