Add typing shorthand for display-related types #10109
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
.. and use it to give a better type hint for supervisor.runtime.display.
elpekenin
reviewed
Mar 2, 2025
shared-bindings/displayio/__init__.c
Outdated
| //| AnyDisplayBus: fourwire.FourWire | i2cdisplaybus.I2cDisplayBus | ||
| //| """Type-checking shorthand for any kind of display bus. Not actually defined in CircuitPython.""" | ||
| //| | ||
| //| AnyFramebuffer: ( |
There was a problem hiding this comment.
I'm pretty sure this should be
Suggested change
| //| AnyFramebuffer: ( | |
| //| AnyFramebuffer = ( |
As in... AnyFramebuffer is any of these types, not an instance of them
On a quick check in a blank file
foo: int | float
bar: foo # Variable not allowed in type expression (by pylance extension on VSCode)foo = int | float
bar: foo # nothing reportedPS: Same thing applies below
There was a problem hiding this comment.
thanks! This is a mistake I commonly make.
|
It turns out the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
.. and use it to give a better type hint for supervisor.runtime.display.