Enable & Address -Wtype-limits diagnostics in raspberrypi port #10187
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes an unlikely problem with the USB host implementation on rp2350 that would not have detected failure to allocate a DMA channel. Together with adafruit#10186 this should give a clean build. As it is, this will error.
jepler
commented
Mar 26, 2025
| @@ -222,7 +222,7 @@ endif | |||
|
|
|||
| DISABLE_WARNINGS = -Wno-cast-align | |||
|
|
|||
| CFLAGS += $(INC) -Wall -Werror -std=gnu11 -fshort-enums $(BASE_CFLAGS) $(CFLAGS_MOD) $(COPT) $(DISABLE_WARNINGS) -Werror=missing-prototypes | |||
| CFLAGS += $(INC) -Wtype-limits -Wall -Werror -std=gnu11 -fshort-enums $(BASE_CFLAGS) $(CFLAGS_MOD) $(COPT) $(DISABLE_WARNINGS) -Werror=missing-prototypes | |||
There was a problem hiding this comment.
this submodule has a harmless -Wtype-limits diagnostic that I didn't want to go through the trouble of fixing.
jepler
dismissed
eightycc’s stale review
The merge-base changed after approval.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes an unlikely problem with the USB host implementation on rp2350 that would not have detected failure to allocate a DMA channel.
Together with #10186 this should give a clean build. As such, this PR includes the current version of #10168 changes. If that PR is rebased, this PR should be rebased as well. The change of interest is 8097e3d