Skip to content

Depend on header inclusion via -isystem #10188

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 26, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions ports/raspberrypi/Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@ HAL_DIR=hal/$(MCU_SERIES)

ifeq ($(CIRCUITPY_CYW43),1)
INC_CYW43 := \
-isystem lib/cyw43-driver \
-isystem lib/cyw43-driver/firmware \
-isystem lib/cyw43-driver/src \
-isystem lib/lwip/src/include \
Expand Down Expand Up @@ -92,8 +93,6 @@ INC += \
-I../shared/timeutils \
-Iboards/$(BOARD) \
-Iboards/ \
-isystem ./../../lib/cmsis/inc \
-isystem sdk/ \
-isystem sdk/src/common/boot_picobin_headers/include/ \
-isystem sdk/src/common/boot_picoboot_headers/include/ \
-isystem sdk/src/common/hardware_claim/include/ \
Expand All @@ -107,6 +106,8 @@ INC += \
-isystem sdk/src/$(CHIP_VARIANT_LOWER)/hardware_structs/include/ \
-isystem sdk/src/$(CHIP_VARIANT_LOWER)/pico_platform/include/ \
-isystem sdk/src/rp2_common/boot_bootrom_headers/include/ \
-isystem sdk/src/rp2_common/cmsis/stub/CMSIS/Core/Include/ \
-isystem sdk/src/rp2_common/cmsis/stub/CMSIS/Device/${CHIP_VARIANT}/Include \
-isystem sdk/src/rp2_common/cmsis/ \
-isystem sdk/src/rp2_common/hardware_adc/include/ \
-isystem sdk/src/rp2_common/hardware_base/include/ \
Expand Down Expand Up @@ -153,7 +154,7 @@ INC += \
-isystem sdk/src/rp2_common/pico_platform_panic/include/ \
-isystem sdk/src/rp2_common/pico_time_adapter/include/ \
-isystem sdk/src/rp2_common/pico_unique_id/include/ \
$(INC_CYW43) \
$(INC_CYW43) \
-Isdk_config \
-I../../lib/tinyusb/src \
-I../../supervisor/shared/usb \
Expand Down
2 changes: 1 addition & 1 deletion ports/raspberrypi/audio_dma.c
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@
#include "py/mpstate.h"
#include "py/runtime.h"

#include "src/rp2_common/hardware_irq/include/hardware/irq.h"
#include "hardware/irq.h"
#include "hardware/regs/intctrl.h" // For isr_ macro.


Expand Down
2 changes: 1 addition & 1 deletion ports/raspberrypi/audio_dma.h
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@
#include "py/obj.h"
#include "supervisor/background_callback.h"

#include "src/rp2_common/hardware_dma/include/hardware/dma.h"
#include "hardware/dma.h"

typedef enum {
AUDIO_DMA_OK,
Expand Down
2 changes: 1 addition & 1 deletion ports/raspberrypi/bindings/cyw43/__init__.c
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@
#include "shared-bindings/microcontroller/Pin.h"
#include "bindings/cyw43/__init__.h"

#include "src/rp2_common/hardware_gpio/include/hardware/gpio.h"
#include "hardware/gpio.h"

#include "lib/cyw43-driver/src/cyw43.h"

Expand Down
2 changes: 1 addition & 1 deletion ports/raspberrypi/boards/adafruit_macropad_rp2040/board.c
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@
#include "shared-module/displayio/mipi_constants.h"
#include "shared-bindings/busio/SPI.h"
#include "shared-bindings/microcontroller/Pin.h"
#include "src/rp2_common/hardware_gpio/include/hardware/gpio.h"
#include "hardware/gpio.h"
#include "supervisor/board.h"
#include "supervisor/shared/board.h"

Expand Down
2 changes: 1 addition & 1 deletion ports/raspberrypi/boards/adafruit_qt2040_trinkey/board.c
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,6 @@
#include "supervisor/board.h"

#include "shared-bindings/microcontroller/Pin.h"
#include "src/rp2_common/hardware_gpio/include/hardware/gpio.h"
#include "hardware/gpio.h"

// Use the MP_WEAK supervisor/shared/board.c versions of routines not defined here.
2 changes: 1 addition & 1 deletion ports/raspberrypi/boards/boardsource_blok/board.c
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@

#include "supervisor/board.h"
#include "shared-bindings/microcontroller/Pin.h"
#include "src/rp2_common/hardware_gpio/include/hardware/gpio.h"
#include "hardware/gpio.h"
#include "supervisor/shared/board.h"

void board_init(void) {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -26,9 +26,9 @@
#include "shared-module/displayio/__init__.h"
#include "supervisor/shared/board.h"

#include "src/rp2_common/hardware_gpio/include/hardware/gpio.h"
#include "hardware/gpio.h"

#include "src/rp2_common/hardware_adc/include/hardware/adc.h"
#include "hardware/adc.h"
#define ADC_FIRST_PIN_NUMBER 26
#define ADC_PIN_COUNT 4
extern void common_hal_mcu_delay_us(uint32_t);
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@

#include "shared-bindings/board/__init__.h"
#include "shared-bindings/microcontroller/Pin.h"
#include "src/rp2_common/hardware_gpio/include/hardware/gpio.h"
#include "hardware/gpio.h"
#include "supervisor/shared/board.h"
#include "supervisor/board.h"

Expand Down
2 changes: 1 addition & 1 deletion ports/raspberrypi/boards/jpconstantineau_pykey18/board.c
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@

#include "supervisor/board.h"
#include "shared-bindings/microcontroller/Pin.h"
#include "src/rp2_common/hardware_gpio/include/hardware/gpio.h"
#include "hardware/gpio.h"
#include "supervisor/shared/board.h"

void reset_board(void) {
Expand Down
2 changes: 1 addition & 1 deletion ports/raspberrypi/boards/jpconstantineau_pykey44/board.c
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@

#include "supervisor/board.h"
#include "shared-bindings/microcontroller/Pin.h"
#include "src/rp2_common/hardware_gpio/include/hardware/gpio.h"
#include "hardware/gpio.h"
#include "supervisor/shared/board.h"

void reset_board(void) {
Expand Down
2 changes: 1 addition & 1 deletion ports/raspberrypi/boards/jpconstantineau_pykey60/board.c
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@

#include "supervisor/board.h"
#include "shared-bindings/microcontroller/Pin.h"
#include "src/rp2_common/hardware_gpio/include/hardware/gpio.h"
#include "hardware/gpio.h"
#include "supervisor/shared/board.h"

void reset_board(void) {
Expand Down
2 changes: 1 addition & 1 deletion ports/raspberrypi/boards/jpconstantineau_pykey87/board.c
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@

#include "supervisor/board.h"
#include "shared-bindings/microcontroller/Pin.h"
#include "src/rp2_common/hardware_gpio/include/hardware/gpio.h"
#include "hardware/gpio.h"
#include "supervisor/shared/board.h"

void reset_board(void) {
Expand Down
2 changes: 1 addition & 1 deletion ports/raspberrypi/boards/ugame22/board.c
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
#include "supervisor/board.h"

#include "shared-bindings/microcontroller/Pin.h"
#include "src/rp2_common/hardware_gpio/include/hardware/gpio.h"
#include "hardware/gpio.h"

#include "shared-bindings/busio/SPI.h"
#include "shared-bindings/fourwire/FourWire.h"
Expand Down
2 changes: 1 addition & 1 deletion ports/raspberrypi/boards/wk-50/board.c
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@

#include "supervisor/board.h"
#include "shared-bindings/microcontroller/Pin.h"
#include "src/rp2_common/hardware_gpio/include/hardware/gpio.h"
#include "hardware/gpio.h"
#include "supervisor/shared/board.h"

void reset_board(void) {
Expand Down
2 changes: 1 addition & 1 deletion ports/raspberrypi/boards/zrichard_rp2.65-f/board.c
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@

#include "supervisor/board.h"
#include "shared-bindings/microcontroller/Pin.h"
#include "src/rp2_common/hardware_gpio/include/hardware/gpio.h"
#include "hardware/gpio.h"
#include "supervisor/shared/board.h"

void reset_board(void) {
Expand Down
8 changes: 4 additions & 4 deletions ports/raspberrypi/boot_stage2/RP2040.c.jinja
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
#include "sdk/src/rp2040/hardware_structs/include/hardware/structs/ssi.h"
#include "sdk/src/rp2040/hardware_structs/include/hardware/structs/pads_qspi.h"
#include "sdk/src/rp2040/hardware_regs/include/hardware/regs/addressmap.h"
#include "sdk/src/rp2040/hardware_regs/include/hardware/regs/m0plus.h"
#include "hardware/structs/ssi.h"
#include "hardware/structs/pads_qspi.h"
#include "hardware/regs/addressmap.h"
#include "hardware/regs/m0plus.h"

// "Mode bits" are 8 special bits sent immediately after
// the address bits in a "Read Data Fast Quad I/O" command sequence.
Expand Down
6 changes: 3 additions & 3 deletions ports/raspberrypi/common-hal/analogbufio/BufferedIn.c
Original file line number Diff line number Diff line change
Expand Up @@ -11,9 +11,9 @@
#include "shared-bindings/microcontroller/Pin.h"
#include "shared/runtime/interrupt_char.h"
#include "py/runtime.h"
#include "src/rp2_common/hardware_adc/include/hardware/adc.h"
#include "src/rp2_common/hardware_dma/include/hardware/dma.h"
#include "src/common/pico_stdlib_headers/include/pico/stdlib.h"
#include "hardware/adc.h"
#include "hardware/dma.h"
#include "pico/stdlib.h"

#define ADC_FIRST_PIN_NUMBER 26
#define ADC_PIN_COUNT 4
Expand Down
2 changes: 1 addition & 1 deletion ports/raspberrypi/common-hal/analogbufio/BufferedIn.h
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@
#pragma once

#include "common-hal/microcontroller/Pin.h"
#include "src/rp2_common/hardware_dma/include/hardware/dma.h"
#include "hardware/dma.h"

#include "py/obj.h"

Expand Down
2 changes: 1 addition & 1 deletion ports/raspberrypi/common-hal/analogio/AnalogIn.c
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@
#include "shared-bindings/microcontroller/Pin.h"
#include "py/runtime.h"

#include "src/rp2_common/hardware_adc/include/hardware/adc.h"
#include "hardware/adc.h"

#define ADC_PIN_COUNT (NUM_ADC_CHANNELS - 1)

Expand Down
4 changes: 2 additions & 2 deletions ports/raspberrypi/common-hal/audiopwmio/PWMAudioOut.c
Original file line number Diff line number Diff line change
Expand Up @@ -20,8 +20,8 @@
#include "shared-bindings/microcontroller/Pin.h"
#include "shared-bindings/microcontroller/Processor.h"

#include "src/rp2040/hardware_structs/include/hardware/structs/dma.h"
#include "src/rp2_common/hardware_pwm/include/hardware/pwm.h"
#include "hardware/structs/dma.h"
#include "hardware/pwm.h"

// The PWM clock frequency is base_clock_rate / PWM_TOP, typically 125_000_000 / PWM_TOP.
// We pick BITS_PER_SAMPLE so we get a clock frequency that is above what would cause aliasing.
Expand Down
2 changes: 1 addition & 1 deletion ports/raspberrypi/common-hal/busio/I2C.c
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@
#include "shared-bindings/microcontroller/Pin.h"
#include "shared-bindings/bitbangio/I2C.h"

#include "src/rp2_common/hardware_gpio/include/hardware/gpio.h"
#include "hardware/gpio.h"

// Synopsys DW_apb_i2c (v2.01) IP

Expand Down
2 changes: 1 addition & 1 deletion ports/raspberrypi/common-hal/busio/I2C.h
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@

#include "py/obj.h"

#include "src/rp2_common/hardware_i2c/include/hardware/i2c.h"
#include "hardware/i2c.h"

typedef struct {
mp_obj_base_t base;
Expand Down
4 changes: 2 additions & 2 deletions ports/raspberrypi/common-hal/busio/SPI.c
Original file line number Diff line number Diff line change
Expand Up @@ -14,8 +14,8 @@
#include "common-hal/microcontroller/Pin.h"
#include "shared-bindings/microcontroller/Pin.h"

#include "src/rp2_common/hardware_dma/include/hardware/dma.h"
#include "src/rp2_common/hardware_gpio/include/hardware/gpio.h"
#include "hardware/dma.h"
#include "hardware/gpio.h"

#define NO_INSTANCE 0xff

Expand Down
2 changes: 1 addition & 1 deletion ports/raspberrypi/common-hal/busio/SPI.h
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@

#include "py/obj.h"

#include "src/rp2_common/hardware_spi/include/hardware/spi.h"
#include "hardware/spi.h"

typedef struct {
mp_obj_base_t base;
Expand Down
4 changes: 2 additions & 2 deletions ports/raspberrypi/common-hal/busio/UART.c
Original file line number Diff line number Diff line change
Expand Up @@ -14,8 +14,8 @@
#include "common-hal/microcontroller/Pin.h"
#include "shared-bindings/microcontroller/Pin.h"

#include "src/rp2_common/hardware_irq/include/hardware/irq.h"
#include "src/rp2_common/hardware_gpio/include/hardware/gpio.h"
#include "hardware/irq.h"
#include "hardware/gpio.h"

#define NO_PIN 0xff

Expand Down
2 changes: 1 addition & 1 deletion ports/raspberrypi/common-hal/busio/UART.h
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@
#include "py/obj.h"
#include "py/ringbuf.h"

#include "src/rp2_common/hardware_uart/include/hardware/uart.h"
#include "hardware/uart.h"

typedef struct {
mp_obj_base_t base;
Expand Down
6 changes: 3 additions & 3 deletions ports/raspberrypi/common-hal/countio/Counter.c
Original file line number Diff line number Diff line change
Expand Up @@ -13,9 +13,9 @@
#include "shared-bindings/digitalio/Pull.h"
#include "common-hal/pwmio/PWMOut.h"

#include "src/rp2_common/hardware_gpio/include/hardware/gpio.h"
#include "src/rp2_common/hardware_pwm/include/hardware/pwm.h"
#include "src/rp2_common/hardware_irq/include/hardware/irq.h"
#include "hardware/gpio.h"
#include "hardware/pwm.h"
#include "hardware/irq.h"


void common_hal_countio_counter_construct(countio_counter_obj_t *self,
Expand Down
2 changes: 1 addition & 1 deletion ports/raspberrypi/common-hal/digitalio/DigitalInOut.c
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@
#include "shared-bindings/microcontroller/Pin.h"
#include "shared-bindings/digitalio/DigitalInOut.h"

#include "src/rp2_common/hardware_gpio/include/hardware/gpio.h"
#include "hardware/gpio.h"

#if CIRCUITPY_CYW43
#include "pico/cyw43_arch.h"
Expand Down
2 changes: 1 addition & 1 deletion ports/raspberrypi/common-hal/i2ctarget/I2CTarget.c
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@
#include "shared-bindings/microcontroller/Pin.h"
#include "py/runtime.h"

#include "src/rp2_common/hardware_gpio/include/hardware/gpio.h"
#include "hardware/gpio.h"

static i2c_inst_t *i2c[2] = {i2c0, i2c1};

Expand Down
2 changes: 1 addition & 1 deletion ports/raspberrypi/common-hal/i2ctarget/I2CTarget.h
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@

#include "py/obj.h"
#include "common-hal/microcontroller/Pin.h"
#include "src/rp2_common/hardware_i2c/include/hardware/i2c.h"
#include "hardware/i2c.h"

typedef struct {
mp_obj_base_t base;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -18,8 +18,8 @@
#include "shared-bindings/microcontroller/Processor.h"
#include "shared-bindings/microcontroller/__init__.h"

#include "src/rp2_common/hardware_pio/include/hardware/pio.h"
#include "src/rp2_common/hardware_pio/include/hardware/pio_instructions.h"
#include "hardware/pio.h"
#include "hardware/pio_instructions.h"

// Define this to (1), and you can scope the instruction-pointer of the state machine on D26..28 (note the weird encoding though!)
#define DEBUG_STATE_MACHINE (0)
Expand Down
2 changes: 1 addition & 1 deletion ports/raspberrypi/common-hal/max3421e/Max3421E.c
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@
#include "shared-bindings/busio/SPI.h"
#include "supervisor/usb.h"

#include "src/rp2_common/hardware_gpio/include/hardware/gpio.h"
#include "hardware/gpio.h"

static max3421e_max3421e_obj_t *active_max = NULL;

Expand Down
2 changes: 1 addition & 1 deletion ports/raspberrypi/common-hal/microcontroller/Pin.c
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@
#include "common-hal/microcontroller/__init__.h"
#include "shared-bindings/microcontroller/Pin.h"

#include "src/rp2_common/hardware_gpio/include/hardware/gpio.h"
#include "hardware/gpio.h"

static uint64_t gpio_bank0_pin_claimed;

Expand Down
25 changes: 10 additions & 15 deletions ports/raspberrypi/common-hal/microcontroller/Processor.c
Original file line number Diff line number Diff line change
Expand Up @@ -15,26 +15,21 @@
#include "shared-bindings/time/__init__.h"

#include "pico/stdlib.h"
#include "src/rp2_common/hardware_adc/include/hardware/adc.h"
#include "src/rp2_common/hardware_clocks/include/hardware/clocks.h"
#include "src/rp2_common/hardware_vreg/include/hardware/vreg.h"
#include "src/rp2_common/hardware_watchdog/include/hardware/watchdog.h"
#include "hardware/adc.h"
#include "hardware/clocks.h"
#include "hardware/vreg.h"
#include "hardware/watchdog.h"

#ifdef PICO_RP2040
#include "src/rp2040/hardware_regs/include/hardware/regs/vreg_and_chip_reset.h"
#include "hardware/regs/vreg_and_chip_reset.h"
#include "hardware/structs/vreg_and_chip_reset.h"
#endif
#ifdef PICO_RP2350
#include "src/rp2350/hardware_regs/include/hardware/regs/powman.h"
#include "hardware/regs/powman.h"
#include "hardware/structs/powman.h"
#endif
#include "src/rp2040/hardware_regs/include/hardware/regs/watchdog.h"

#ifdef PICO_RP2040
#include "src/rp2040/hardware_structs/include/hardware/structs/vreg_and_chip_reset.h"
#endif
#ifdef PICO_RP2350
#include "src/rp2350/hardware_structs/include/hardware/structs/powman.h"
#endif
#include "src/rp2040/hardware_structs/include/hardware/structs/watchdog.h"
#include "hardware/regs/watchdog.h"
#include "hardware/structs/watchdog.h"

float common_hal_mcu_processor_get_temperature(void) {
adc_init();
Expand Down
2 changes: 1 addition & 1 deletion ports/raspberrypi/common-hal/microcontroller/Processor.h
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@

#pragma once

#include "src/rp2_common/pico_unique_id/include/pico/unique_id.h"
#include "pico/unique_id.h"

#define COMMON_HAL_MCU_PROCESSOR_UID_LENGTH PICO_UNIQUE_BOARD_ID_SIZE_BYTES

Expand Down
Loading