Skip to content

Tweak audio playback on RP2 #10299

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 30, 2025
Merged

Conversation

tannewt
Copy link
Member

@tannewt tannewt commented Apr 29, 2025

This will hopefully make it more reliable. I think the failure to play was due to a latent interrupt from the previously interrupted playback.

This will hopefully make it more reliable. I think the failure to
play was due to a latent interrupt from the previously interrupted
playback.
@tannewt tannewt added this to the 10.0.0 milestone Apr 29, 2025
@tannewt tannewt requested a review from gamblor21 April 29, 2025 21:06
Copy link
Member

@gamblor21 gamblor21 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good. I could not get the audio to fail in my testing. I'll approve and up to you if you want to wait for anyone else to try to "break" it.

Thanks for the fix! I know from experience how crazy chasing audio race conditions is.

@tannewt tannewt merged commit 88f6117 into adafruit:main Apr 30, 2025
159 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants