Added support for Sunton 1.28" Display ESP32C3 device. #9110
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Do you have one of these boards and are adding the board so you can use it? |
|
I do have one. I am using it. I thought it might be useful for others, so I shared what I came up with. It's the same form factor as the Waveshare 1.28 rp2040, but with an ESP32. |
dhalbert
requested changes
Mar 29, 2024
Comment on lines
+11
to
+13
| // IO8. This is on the schematic linked to a 10k pull up and "S1" | ||
| // No further indication of what "S1" is or what this pin is for | ||
| { MP_ROM_QSTR(MP_QSTR_IO8), MP_ROM_PTR(&pin_GPIO8) }, |
There was a problem hiding this comment.
In this picture, from https://www.luisllamas.es/en/sunton-esp32-round/, I see a switch, maybe that's it?
There was a problem hiding this comment.
It is not. That only ties to the power management chip.
dhalbert
approved these changes
Mar 29, 2024
There was a problem hiding this comment.
This looks fine. Thanks. Please submit a PR to https://github.com/adafruit/circuitpython-org as well with board details. See https://learn.adafruit.com/how-to-add-a-new-board-to-the-circuitpython-org-website.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added support for this 1.28" Touchscreen LCD ESP32C3 based device. Working built in spi display, i2c touch and user buttons.