Skip to content

Add ESP BLE GATT server support #9222

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 17, 2024
Merged

Conversation

tannewt
Copy link
Member

@tannewt tannewt commented May 3, 2024

Enable BLE where we can. Switch 4MB, non-USB board default partitioning over to a single 2MB firmware bank. Old boards override this setting to keep the same behavior.

This also adds alpha support for the ESP32-C2 (aka ESP8684).

Fixes #5926 and #7170

@tannewt
Copy link
Member Author

tannewt commented May 3, 2024

Seems to work on S3. Connecting hangs on C6. C2 runs out of memory with wifi on. C3 is untested. ESP32 crashes with watchdog timeout. (EDIT: update, see below)

Enable BLE where we can. Switch 4MB, non-USB board default partitioning
over to a single 2MB firmware bank. Old boards override this setting to
keep the same behavior.

This also adds alpha support for the ESP32-C2 (aka ESP8684).

Fixes micropython#5926 and fixes micropython#7170
@tannewt tannewt requested a review from dhalbert May 17, 2024 18:10
@tannewt tannewt marked this pull request as ready for review May 17, 2024 18:10
@tannewt
Copy link
Member Author

tannewt commented May 17, 2024

This should be good to go!

Copy link
Collaborator

@dhalbert dhalbert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this lib/tinyusb submodule change a regression? I thought it was bumped forward in another PR.

Just some other questions. I did not test. I will put the "this and that don't work" in the release notes. When this is merged, could you add issues addressing the ports that don't work? Thanks.

@tannewt
Copy link
Member Author

tannewt commented May 17, 2024

Is this lib/tinyusb submodule change a regression? I thought it was bumped forward in another PR.

This bumps it further add definitions for the C2.

Just some other questions. I did not test. I will put the "this and that don't work" in the release notes. When this is merged, could you add issues addressing the ports that don't work? Thanks.

I'm not sure what you mean by this. I hope it all works but I expect folks to find issues.

@dhalbert
Copy link
Collaborator

dhalbert commented May 17, 2024

I'm not sure what you mean by this. I hope it all works but I expect folks to find issues.

I meant what you said in the post above:

Connecting hangs on C6. C2 runs out of memory with wifi on. C3 is untested. ESP32 crashes with watchdog timeout.

C2 is not surprising. So C6 and ESP32 needs some fixing, and C3 needs to be tested.

@tannewt
Copy link
Member Author

tannewt commented May 17, 2024

Ah! I think C6 and ESP32 are fixed.RAM may still be an issue but we'll see.

@dhalbert dhalbert merged commit 6c4bfd6 into adafruit:main May 17, 2024
511 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add BLE GATT server support to espressif port
2 participants