-
Notifications
You must be signed in to change notification settings - Fork 1.3k
Add ESP BLE GATT server support #9222
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Seems to work on S3. |
Enable BLE where we can. Switch 4MB, non-USB board default partitioning over to a single 2MB firmware bank. Old boards override this setting to keep the same behavior. This also adds alpha support for the ESP32-C2 (aka ESP8684). Fixes micropython#5926 and fixes micropython#7170
This should be good to go! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this lib/tinyusb submodule change a regression? I thought it was bumped forward in another PR.
Just some other questions. I did not test. I will put the "this and that don't work" in the release notes. When this is merged, could you add issues addressing the ports that don't work? Thanks.
This bumps it further add definitions for the C2.
I'm not sure what you mean by this. I hope it all works but I expect folks to find issues. |
I meant what you said in the post above:
C2 is not surprising. So C6 and ESP32 needs some fixing, and C3 needs to be tested. |
Ah! I think C6 and ESP32 are fixed.RAM may still be an issue but we'll see. |
Enable BLE where we can. Switch 4MB, non-USB board default partitioning over to a single 2MB firmware bank. Old boards override this setting to keep the same behavior.
This also adds alpha support for the ESP32-C2 (aka ESP8684).
Fixes #5926 and #7170