add odt rpga feather #9292
Merged
add odt rpga feather #9292
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dhalbert
requested changes
Jun 5, 2024
dhalbert
requested changes
Jun 5, 2024
dhalbert
requested changes
Jun 5, 2024
dhalbert
requested changes
Jun 5, 2024
| #define DEFAULT_I2C_BUS_SDA (&pin_GPIO11) | ||
|
|
||
| #define CIRCUITPY_BOARD_I2C (2) | ||
| #define CIRCUITPY_BOARD_I2C_PIN {{.scl = &pin_GPIO10, .sda = &pin_GPIO11}, \ |
There was a problem hiding this comment.
10/11 SCL/SDA is still reversed from what's in pins.c.
|
Of course make a PR to https://github.com/adafruit/circuitpython-org now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a CircuitPython build for RPGA Feather. PID is under review with pid.codes. I've tested this on my boards and it works as expected.