Skip to content

add ARCHI NEWSAN board #9353

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Jun 26, 2024
Merged

add ARCHI NEWSAN board #9353

merged 10 commits into from
Jun 26, 2024

Conversation

EricAlmendras
Copy link

No description provided.

Copy link
Collaborator

@dhalbert dhalbert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, one minor thing, and one comment about the frozen modules.

Comment on lines 14 to 16
FROZEN_MPY_DIRS += $(TOP)/frozen/Adafruit_CircuitPython_MPU6050
FROZEN_MPY_DIRS += $(TOP)/frozen/Adafruit_CircuitPython_Pixel_Framebuf
FROZEN_MPY_DIRS += $(TOP)/frozen/Adafruit_CircuitPython_Led_Animation
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You'll need to add these as frozen libraries to .gitmodules. Do a git submodule add.
Note that for Adafruit_CircuitPython_LED_Animation, the LED is all capital letters.
You had NeoPixel here before. Did you want to add it back? It's already in frozen/.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have already corrected it

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we take out the Adafruit_CircuitPython_Led_Animation

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure. It is still in .gitmodules in the latest push, though. Also did you want NeoPixel in or out?

@EricAlmendras EricAlmendras requested a review from dhalbert June 19, 2024 19:12
Copy link
Collaborator

@dhalbert dhalbert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You changed copyrights in the files in ports/raspberrypi/boards/odt_rpga_feather. But that is not your board. Did you mean to do that?

@EricAlmendras
Copy link
Author

sorry, I didn't want to change the file copyright in ports/raspberrypi/boards/odt_rpga_feather, I wanted to change it in my files, corrected.

@EricAlmendras EricAlmendras requested a review from dhalbert June 24, 2024 10:35
Copy link
Collaborator

@dhalbert dhalbert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing the copyrights. I still have some remaining remarks about the frozen libraries.

@EricAlmendras EricAlmendras requested a review from dhalbert June 24, 2024 14:23
EricAlmendras and others added 2 commits June 24, 2024 11:34
Co-authored-by: Dan Halbert <halbert@halwitz.org>
Co-authored-by: Dan Halbert <halbert@halwitz.org>
@EricAlmendras EricAlmendras requested a review from dhalbert June 24, 2024 14:36
@EricAlmendras
Copy link
Author

EricAlmendras commented Jun 26, 2024

Sorry, I added LED_Animation again, I had removed it before.

Copy link
Collaborator

@dhalbert dhalbert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, I think we're all set here. Thanks for your perseverance!

@dhalbert dhalbert merged commit f1d29ee into adafruit:main Jun 26, 2024
523 of 524 checks passed
@dhalbert
Copy link
Collaborator

Could you also submit a board description to https://github.com/adafruit/circuitpython-org ? Guide to doing that is here: https://learn.adafruit.com/how-to-add-a-new-board-to-the-circuitpython-org-website

@EricAlmendras
Copy link
Author

I will, thank you very much.

@EricAlmendras EricAlmendras deleted the archi-board branch June 26, 2024 16:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants