-
Notifications
You must be signed in to change notification settings - Fork 1.3k
add ARCHI NEWSAN board #9353
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add ARCHI NEWSAN board #9353
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi, one minor thing, and one comment about the frozen modules.
FROZEN_MPY_DIRS += $(TOP)/frozen/Adafruit_CircuitPython_MPU6050 | ||
FROZEN_MPY_DIRS += $(TOP)/frozen/Adafruit_CircuitPython_Pixel_Framebuf | ||
FROZEN_MPY_DIRS += $(TOP)/frozen/Adafruit_CircuitPython_Led_Animation |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You'll need to add these as frozen libraries to .gitmodules. Do a git submodule add
.
Note that for Adafruit_CircuitPython_LED_Animation
, the LED is all capital letters.
You had NeoPixel
here before. Did you want to add it back? It's already in frozen/
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have already corrected it
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we take out the Adafruit_CircuitPython_Led_Animation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure. It is still in .gitmodules
in the latest push, though. Also did you want NeoPixel in or out?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You changed copyrights in the files in ports/raspberrypi/boards/odt_rpga_feather
. But that is not your board. Did you mean to do that?
sorry, I didn't want to change the file copyright in ports/raspberrypi/boards/odt_rpga_feather, I wanted to change it in my files, corrected. |
ab0acdd
to
86f8d93
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for fixing the copyrights. I still have some remaining remarks about the frozen libraries.
Co-authored-by: Dan Halbert <halbert@halwitz.org>
Co-authored-by: Dan Halbert <halbert@halwitz.org>
Sorry, I added LED_Animation again, I had removed it before. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK, I think we're all set here. Thanks for your perseverance!
Could you also submit a board description to https://github.com/adafruit/circuitpython-org ? Guide to doing that is here: https://learn.adafruit.com/how-to-add-a-new-board-to-the-circuitpython-org-website |
I will, thank you very much. |
No description provided.