Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integration Test setup: fix relative path error for Android SDK #102

Merged
merged 3 commits into from
Jun 27, 2023

Conversation

aSemy
Copy link
Contributor

@aSemy aSemy commented Jun 26, 2023

Fix this error which happens on GitHub Windows CI

IllegalArgumentException: this and base files have different roots: C:\Android\android-sdk and D:\a\dokkatoo\dokkatoo\modules\dokkatoo-plugin-integration-tests.

@aSemy aSemy added this to the v1.5.1 milestone Jun 26, 2023
@aSemy aSemy changed the title fix relative path error for Android SDK Integration Test setup: fix relative path error for Android SDK Jun 26, 2023
aSemy added 3 commits June 27, 2023 01:01
```
IllegalArgumentException: this and base files have different roots: C:\Android\android-sdk and D:\a\dokkatoo\dokkatoo\modules\dokkatoo-plugin-integration-tests.
```
Also tidy up for loop to avoid a nested statement
@aSemy aSemy force-pushed the fix/windows_android_sdk_path branch from 9185a3a to dc4fad4 Compare June 26, 2023 23:02
@aSemy aSemy merged commit ad3fac0 into main Jun 27, 2023
@aSemy aSemy deleted the fix/windows_android_sdk_path branch June 27, 2023 05:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant