Add disableThirdPartySharing method on Adjust SDK
#15
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tp
force-pushed
the
disable-third-party-tracking
branch
from
4183d38 to
31138b3
Compare
|
Would've liked to update the SDK to 4.21.0 already, but that seems to come with some breaking changes, so I stayed with the minimal amount of changes here. |
|
Wow @tp, pretty impressive, thanks for this! 👏 What breaking changes did you notice with 4.21.0? |
Just 3 compile errors. Probably nothing major, but I needed to apply the migration steps outlined here: https://github.com/adjust/ios_sdk/blob/master/doc/migrate.md |
|
👍 No need to worry about that, we can take it from here and do few minor things for alignment with 4.21.0, this what you did is already majority of work done. Thank you one more time, we'll try to push this update as soon as we can. |
Merged
|
Replaced with #16. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.