[Release] Stage to Main #3880

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

milo-pr-merge merged 9 commits into main from stage

Apr 1, 2025

Contributor

milo-pr-merge bot commented Mar 31, 2025

common base root URLs

Homepage : https://www.stage.adobe.com/
BACOM: https://business.stage.adobe.com/fr/
CC: https://www.stage.adobe.com/creativecloud.html
Blog: https://blog.stage.adobe.com/
Acrobat: https://www.stage.adobe.com/acrobat/online/sign-pdf.html

Milo:

jpratt2 and others added 9 commits

March 31, 2025 08:26


          [MEP][NALA] add mep tag to all personalization nala tests (#3871)

add mep tag for folder launches

Co-authored-by: John Pratt <jpratt@adobe.com>


          [OPT-31058] Test block support for EMEA-1435 (#3878)

609e09e

* emea1435

* updated to version that actually supports tabs

* lint fixes


          MWPW-162956: Setting accessibleLabel as sr-only (#3738)

d7014b4

* Setting accessibleLabel as sr-only

* mid

* Adding logic for <sr-only>Alternatively at</sr-only>

* Applying some of Ilyas comment

* 2'

* 2'

* merge

* Sending flag into template.js to generate <sr-only>

* nit: trying to improve the readability

* nit: Rebuild the mas

* Having parentEl dataset for merch price in merch.js

* Adding a test for alternativePrice option for aria label (sr-only)

* update the logic

* Trying to avoid a bug that adding alternativePrice label to random one when there are many inline prices in a P.

* Support for &alt=true param for mas price link.

* Setting update

* test update.

* nit: polish the code

* Optical & alternative price case handling.

* Restore the priceOptical method.

* Adding alternative price option for annual template.

* This should covers AI bundle case.

* Fixing issue with placeholder-failed on stikethrough


          MWPW-168302: [3-in-1] Modal Error message - if commerce times out (#3831

430af0e

)

* added error msg logic

* added test for timeout error

* more unit tests

* cleaning

* added checkout-link-sandbox

* updated placeholder keys, enhanced icon title

* corrected placeholders

* checkout-link-sandbox changed to 'on'

* removed unnecessary const

* added placeholders

* updated unit tests


          [MWPW-168529] New Assets tab in Preflight (#3835)

79058c7

* Assets preflight POC

* Screen size prompt. Consolidate with a11y

* Handle full width images

* Handle PR feedback


          MWPW-168447: Enable to override aria-label on checkout link via word …

31ab20d

…doc (#3836)

* Enable to override aria-label on checkout link via word doc ("CTA Text|Aria Label")

* Added a comment.


          MWPW-169294: Update ar locale (#3858)

d9df978

* MWPW-169294: Update ar locale

* MWPW-169294: Change font


          MWPW-160751 - Preflight - Adjust section height limit (#3859)

548cf48

* Adjusting the max height limit so Preflight doesn't trunck a very long list of items.

Resolves: [MWPW-160751](MWPW-URL)

**Test URLs:**
- Before: https://stage--milo--adobecom.hlx.page/?martech=off
- After: https://<branch>--milo--adobecom.hlx.page/?martech=off

Co-authored-by: Ryan Clayton <rclayton@adobe.com>


          MWPW-169775: Add classes for removing borders (#3867)

bf86d96

Contributor Author

milo-pr-merge bot commented Mar 31, 2025

Testing can start @adobecom/bacom-sot @adobecom/creative-cloud-sot @adobecom/document-cloud-sot @adobecom/express-sot @adobecom/homepage-sot @adobecom/miq-sot

milo-pr-merge bot requested a review from a team as a code owner

March 31, 2025 08:27

Contributor

aem-code-sync bot commented Mar 31, 2025 •

edited

Loading

Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed.
In case there are problems, just click a checkbox below to rerun the respective action.

Re-run PSI checks
Re-sync branch

Commits

bf86d96 ✅ (latest)
548cf48 ✅
d9df978 ✅
31ab20d ✅
79058c7 ✅
430af0e ✅
d7014b4 ✅
609e09e ✅
5307425 ✅

Contributor

aem-code-sync bot commented Mar 31, 2025

	Page	Scores	Audits	Google
📱	/?martech=off
🖥️	/?martech=off

github-actions bot reviewed

View reviewed changes

Contributor

github-actions bot left a comment

Remaining comments which cannot be posted as a review comment to avoid GitHub Rate Limit

eslint

⚠️ [eslint] _{reported by reviewdog 🐶}
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

https://github.com/adobecom/milo/blob/bf86d9614698b98cdc31a88ed6243a0539e6ae89/libs/features/mas/src/price/template.js

⚠️ [eslint] _{reported by reviewdog 🐶}
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

https://github.com/adobecom/milo/blob/bf86d9614698b98cdc31a88ed6243a0539e6ae89/libs/features/mas/src/settings.js

⚠️ [eslint] _{reported by reviewdog 🐶}
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

https://github.com/adobecom/milo/blob/bf86d9614698b98cdc31a88ed6243a0539e6ae89/libs/features/mas/test/mas-commerce-service.test.js

⚠️ [eslint] _{reported by reviewdog 🐶}
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

https://github.com/adobecom/milo/blob/bf86d9614698b98cdc31a88ed6243a0539e6ae89/libs/features/mas/test/price.test.js

github-actions bot reviewed

View reviewed changes

libs/deps/mas/commerce.js

Contributor

github-actions bot Mar 31, 2025

⚠️ [eslint] _{reported by reviewdog 🐶}
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

github-actions bot reviewed

View reviewed changes

libs/deps/mas/mas.js

Contributor

github-actions bot Mar 31, 2025

⚠️ [eslint] _{reported by reviewdog 🐶}
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

github-actions bot reviewed

View reviewed changes

libs/deps/mas/merch-card.js

Contributor

github-actions bot Mar 31, 2025

⚠️ [eslint] _{reported by reviewdog 🐶}
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

github-actions bot reviewed

View reviewed changes

libs/features/mas/dist/mas.js

Contributor

github-actions bot Mar 31, 2025

⚠️ [eslint] _{reported by reviewdog 🐶}
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

github-actions bot reviewed

View reviewed changes

libs/features/mas/src/defaults.js

Contributor

github-actions bot Mar 31, 2025

⚠️ [eslint] _{reported by reviewdog 🐶}
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

github-actions bot reviewed

View reviewed changes

libs/features/mas/src/external.js

Contributor

github-actions bot Mar 31, 2025

⚠️ [eslint] _{reported by reviewdog 🐶}
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

github-actions bot reviewed

View reviewed changes

libs/features/mas/src/global.css.js

Contributor

github-actions bot Mar 31, 2025

⚠️ [eslint] _{reported by reviewdog 🐶}
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

github-actions bot reviewed

View reviewed changes

libs/features/mas/src/inline-price.js

Contributor

github-actions bot Mar 31, 2025

⚠️ [eslint] _{reported by reviewdog 🐶}
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

github-actions bot reviewed

View reviewed changes

libs/features/mas/src/price.js

Contributor

github-actions bot Mar 31, 2025

⚠️ [eslint] _{reported by reviewdog 🐶}
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

github-actions bot reviewed

View reviewed changes

libs/features/mas/src/price/index.js

Contributor

github-actions bot Mar 31, 2025

⚠️ [eslint] _{reported by reviewdog 🐶}
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

aem-code-sync bot deployed to ratko-test

March 31, 2025 08:44

View deployment

mokimo temporarily deployed to milo_pr_merge

March 31, 2025 09:18

— with

GitHub Actions Inactive

mokimo temporarily deployed to milo_pr_merge

March 31, 2025 12:32

— with

GitHub Actions Inactive

Roycethan approved these changes

View reviewed changes

Roycethan added the Homepage SOT 👌 label

Roycethan temporarily deployed to milo_pr_merge

March 31, 2025 16:19

— with

GitHub Actions Inactive

mokimo temporarily deployed to milo_pr_merge

March 31, 2025 16:19

— with

GitHub Actions Inactive

mokimo temporarily deployed to milo_pr_merge

March 31, 2025 20:17

— with

GitHub Actions Inactive

Dli3 approved these changes

View reviewed changes

Dli3 added the BAcom SOT 👌 label

Dli3 temporarily deployed to milo_pr_merge

March 31, 2025 23:29

— with

GitHub Actions Inactive

tedAir self-requested a review

April 1, 2025 01:03

mokimo temporarily deployed to milo_pr_merge

April 1, 2025 01:22

— with

GitHub Actions Inactive

tedAir approved these changes

View reviewed changes

tedAir added the DC SOT 👌 label

tedAir temporarily deployed to milo_pr_merge

April 1, 2025 02:51

— with

GitHub Actions Inactive

mokimo temporarily deployed to milo_pr_merge

April 1, 2025 04:18

— with

GitHub Actions Inactive

sigadamvenkata commented Apr 1, 2025

we could see some image, CTA overlap issues in home page for locales. issue logged for double check from home page team https://jira.corp.adobe.com/browse/MWPW-170651 . till the investigation and update comes , we are halting the PR merge.

sigadamvenkata requested changes

View reviewed changes

sigadamvenkata left a comment

we could see some image, CTA overlap issues in home page for locales. issue logged for double check from home page team https://jira.corp.adobe.com/browse/MWPW-170651 . till the investigation and update comes , we are halting the PR merge.

sigadamvenkata approved these changes

View reviewed changes

sigadamvenkata left a comment

Approving PR. as per update given in https://jira.corp.adobe.com/browse/MWPW-170651 , issue what reported is known issue in stage and production content will be controlled via campaign and issue will not exist there.

sigadamvenkata added the CC SOT 👌 label

sigadamvenkata temporarily deployed to milo_pr_merge

April 1, 2025 08:15

— with

GitHub Actions Inactive

milo-pr-merge bot merged commit 7025628 into main

40 of 41 checks passed

milo-pr-merge bot temporarily deployed to milo_pr_merge

April 1, 2025 08:15

Inactive

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

github-actions[bot] github-actions[bot] left review comments

tedAir tedAir approved these changes

Dli3 Dli3 approved these changes

Roycethan Roycethan approved these changes

sigadamvenkata sigadamvenkata approved these changes

Labels

BAcom SOT 👌 CC SOT 👌 DC SOT 👌 Homepage SOT 👌