Default to both REPL and console printing #43
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Weasel by default overwrites the *print-fn* global variable to redirect all printing to the REPL after the REPL connection has been opened. In practice this means that if you are using boot-cljs-repl and are also printing to the console via `(enable-console-print)`, your console printing will work for an abritrary period of time until it doesn't anymore. This patch configures Weasel to set the *print-fn* to print to the REPL and the console. IMO, this is the best default to ensure that users aren't confused when half print statements stop working. It's not at all obvious that what the cause is and the amount of people that will be run into this problem is large. I'm also open to exposing this as an option for the task, if you think that's a good idea. Addresses this issue: adzerk-oss#26
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Weasel by default overwrites the
*print-fn*global variable to redirect all printing to the REPL after the REPL connection has been opened. In practice this means that if you are using boot-cljs-repl and are also printing to the console via(enable-console-print), your console printing will work for an abritrary period of time until it doesn't anymore.This patch configures Weasel to set the
*print-fn*to print to the REPL and the console. IMO, this is the best default to ensure that users aren't confused when half their print statements stop working. It's not at all obvious that what the cause is and the amount of people that will be run into this problem is large.I'm also open to exposing this as an option for the task, if you think that's a good idea.
Addresses this issue: #26