-
Notifications
You must be signed in to change notification settings - Fork 209
[ENH] add a difference transformer to series transformations #2729
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Thank you for contributing to
|
It seems that one of the automated checks failed with errors indicating it couldn't find the merge base or my commit SHA:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, few comments.
I have made som modifications according to your comments. @MatthewMiddlehurst |
@MatthewMiddlehurst I am wondering if you could give it a quick look when you get a chance? Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM for the most part, just one documentation bit.
The time series are supposed to be all in rows, | ||
with shape (n_channels, n_timepoints) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Don't need this part, it should be all documented higher up in the base class axis parameter stuff
Reference Issues/PRs
fixes #1553
What does this implement/fix? Explain your changes.
This implements a transformer that computes the n-order differences of a time series.
The input time series is expected to have a NumPy inner-type, and the transformation is performed using numpy.diff().
To preserve the original shape of the series along the time axis, the first order element(s) of the output are filled with NaN.
Does your contribution introduce a new dependency? If yes, which one?
No. It only depends on NumPy.
Any other comments?
No.
PR checklist
For all contributions
For new estimators and functions
__maintainer__
at the top of relevant files and want to be contacted regarding its maintenance. Unmaintained files may be removed. This is for the full file, and you should not add yourself if you are just making minor changes or do not want to help maintain its contents.For developers with write access