Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Update aggOracle docs #174

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

Conversation

rachit77
Copy link
Contributor

Description

Update aggOracle docs to include config explanation

@rachit77 rachit77 self-assigned this Jan 28, 2025
@rachit77 rachit77 changed the title Docs: Update aggOracle docs docs: Update aggOracle docs Jan 28, 2025
@Stefan-Ethernal
Copy link
Contributor

Just an idea:
probably it would be a good idea to describe the configuration parameters for the EthTxManager in some separate doc and reference it from there. The same would go for the Etherman (because it is nested in the EthTxManager). WDYT?

Copy link
Contributor

@joanestebanr joanestebanr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe make sense to set the defaults values and mention that is taking advantage of the common vars like: L1URL, L2URL,....

@rachit77
Copy link
Contributor Author

rachit77 commented Feb 7, 2025

Just an idea: probably it would be a good idea to describe the configuration parameters for the EthTxManager in some separate doc and reference it from there. The same would go for the Etherman (because it is nested in the EthTxManager). WDYT?

Will do the same in a separate PR

@rachit77
Copy link
Contributor Author

rachit77 commented Feb 7, 2025

Maybe make sense to set the defaults values and mention that is taking advantage of the common vars like: L1URL, L2URL,....

I have pointed out to default.go file which contains all the default values

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants