-
Notifications
You must be signed in to change notification settings - Fork 5
feat: python client SDK #94
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
93834ef
to
1d936d0
Compare
Taskfile.yml
Outdated
@@ -169,7 +169,7 @@ tasks: | |||
## | |||
client:test: | |||
desc: Unit test Client code | |||
dir: ./client | |||
dir: ./client/go |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lets keep the client golanf code as is and move only the python code to 'sdk/python/client'. i would only suggest to keep the location of golang code as is
60e8e7c
to
61d28d2
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As discussed, we should look into keeping the generated code under the api
directory like we have for go
api/buf.gen.yaml
Outdated
- remote: buf.build/protocolbuffers/pyi:v30.2 | ||
out: ../client/python/client/proto |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why do we need this protocolbuffers/pyi
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if you check the generated .pyi
files there are the actual classes defined, without them we can't import nothing because there nothing to import
Signed-off-by: Tagscherer Ádám <adam.tagscherer@gmail.com>
Signed-off-by: Tagscherer Ádám <adam.tagscherer@gmail.com>
Signed-off-by: Tagscherer Ádám <adam.tagscherer@gmail.com>
Signed-off-by: Tagscherer Ádám <adam.tagscherer@gmail.com>
Signed-off-by: Tagscherer Ádám <adam.tagscherer@gmail.com>
Signed-off-by: Tagscherer Ádám <adam.tagscherer@gmail.com>
Signed-off-by: Tagscherer Ádám <adam.tagscherer@gmail.com>
Signed-off-by: Tagscherer Ádám <adam.tagscherer@gmail.com>
Signed-off-by: Tagscherer Ádám <adam.tagscherer@gmail.com>
Signed-off-by: Tagscherer Ádám <adam.tagscherer@gmail.com>
Signed-off-by: Tagscherer Ádám <adam.tagscherer@gmail.com>
Signed-off-by: Tagscherer Ádám <adam.tagscherer@gmail.com>
Signed-off-by: Tagscherer Ádám <adam.tagscherer@gmail.com>
Signed-off-by: Tagscherer Ádám <adam.tagscherer@gmail.com>
Signed-off-by: Tagscherer Ádám <adam.tagscherer@gmail.com>
Signed-off-by: Tagscherer Ádám <adam.tagscherer@gmail.com>
Signed-off-by: Tagscherer Ádám <adam.tagscherer@gmail.com>
Signed-off-by: Tagscherer Ádám <adam.tagscherer@gmail.com>
Signed-off-by: Tagscherer Ádám <adam.tagscherer@gmail.com>
Signed-off-by: Tagscherer Ádám <adam.tagscherer@gmail.com>
Signed-off-by: Tagscherer Ádám <adam.tagscherer@gmail.com>
Signed-off-by: Tagscherer Ádám <adam.tagscherer@gmail.com>
Signed-off-by: Tagscherer Ádám <adam.tagscherer@gmail.com>
Signed-off-by: Tagscherer Ádám <adam.tagscherer@gmail.com>
Signed-off-by: Tagscherer Ádám <adam.tagscherer@gmail.com>
Signed-off-by: Tagscherer Ádám <adam.tagscherer@gmail.com>
851fa71
to
87932a6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM ✅
Remember to create a story to add an E2E test for this new client
Signed-off-by: Tagscherer Ádám <adam.tagscherer@gmail.com>
This PR adds the python client SDK, that can be used to call the server's methods from python code.