Skip to content

feat: python client SDK #94

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 27 commits into
base: main
Choose a base branch
from
Open

Conversation

adamtagscherer
Copy link
Member

This PR adds the python client SDK, that can be used to call the server's methods from python code.

@adamtagscherer adamtagscherer added the enhancement New feature or request label Apr 10, 2025
@adamtagscherer adamtagscherer self-assigned this Apr 10, 2025
@adamtagscherer adamtagscherer requested a review from a team as a code owner April 10, 2025 12:32
@adamtagscherer adamtagscherer force-pushed the feat/python-client-sdk branch from 93834ef to 1d936d0 Compare April 10, 2025 12:33
@adamtagscherer adamtagscherer changed the title Feat: python client SDK feat: python client SDK Apr 10, 2025
Taskfile.yml Outdated
@@ -169,7 +169,7 @@ tasks:
##
client:test:
desc: Unit test Client code
dir: ./client
dir: ./client/go
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lets keep the client golanf code as is and move only the python code to 'sdk/python/client'. i would only suggest to keep the location of golang code as is

Copy link
Member

@paralta paralta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As discussed, we should look into keeping the generated code under the api directory like we have for go

api/buf.gen.yaml Outdated
Comment on lines 30 to 31
- remote: buf.build/protocolbuffers/pyi:v30.2
out: ../client/python/client/proto
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why do we need this protocolbuffers/pyi?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if you check the generated .pyi files there are the actual classes defined, without them we can't import nothing because there nothing to import

@adamtagscherer adamtagscherer requested a review from paralta April 15, 2025 14:44
Signed-off-by: Tagscherer Ádám <adam.tagscherer@gmail.com>
Signed-off-by: Tagscherer Ádám <adam.tagscherer@gmail.com>
Signed-off-by: Tagscherer Ádám <adam.tagscherer@gmail.com>
Signed-off-by: Tagscherer Ádám <adam.tagscherer@gmail.com>
Signed-off-by: Tagscherer Ádám <adam.tagscherer@gmail.com>
Signed-off-by: Tagscherer Ádám <adam.tagscherer@gmail.com>
Signed-off-by: Tagscherer Ádám <adam.tagscherer@gmail.com>
Signed-off-by: Tagscherer Ádám <adam.tagscherer@gmail.com>
Signed-off-by: Tagscherer Ádám <adam.tagscherer@gmail.com>
Signed-off-by: Tagscherer Ádám <adam.tagscherer@gmail.com>
Signed-off-by: Tagscherer Ádám <adam.tagscherer@gmail.com>
Signed-off-by: Tagscherer Ádám <adam.tagscherer@gmail.com>
Signed-off-by: Tagscherer Ádám <adam.tagscherer@gmail.com>
Signed-off-by: Tagscherer Ádám <adam.tagscherer@gmail.com>
Signed-off-by: Tagscherer Ádám <adam.tagscherer@gmail.com>
Signed-off-by: Tagscherer Ádám <adam.tagscherer@gmail.com>
Signed-off-by: Tagscherer Ádám <adam.tagscherer@gmail.com>
Signed-off-by: Tagscherer Ádám <adam.tagscherer@gmail.com>
Signed-off-by: Tagscherer Ádám <adam.tagscherer@gmail.com>
Signed-off-by: Tagscherer Ádám <adam.tagscherer@gmail.com>
Signed-off-by: Tagscherer Ádám <adam.tagscherer@gmail.com>
Signed-off-by: Tagscherer Ádám <adam.tagscherer@gmail.com>
Signed-off-by: Tagscherer Ádám <adam.tagscherer@gmail.com>
Signed-off-by: Tagscherer Ádám <adam.tagscherer@gmail.com>
Signed-off-by: Tagscherer Ádám <adam.tagscherer@gmail.com>
Signed-off-by: Tagscherer Ádám <adam.tagscherer@gmail.com>
@adamtagscherer adamtagscherer force-pushed the feat/python-client-sdk branch from 851fa71 to 87932a6 Compare April 15, 2025 14:50
Copy link
Member

@paralta paralta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ✅

Remember to create a story to add an E2E test for this new client

Signed-off-by: Tagscherer Ádám <adam.tagscherer@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants