fix apiMiddleware must not return promise on actions without [CALL_API] #80
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
+1 |
olslash
added a commit
to olslash/redux-api-middleware
that referenced
this pull request
Feb 5, 2017
|
@nason I've migrated to v2 and although following the upgrading guidelines my app was broken. After several hours debugging I've stumbled upon this PR and it made all sense. I had sections of code relying that dispatch returns a promise. IMO this change should be mentioned in the |
eladlevy
pushed a commit
to eladlevy/redux-api-middleware
that referenced
this pull request
Feb 27, 2018
apiMiddleware no longer returns a promise on actions without [RSAA] relates to agraboso#80
This was referenced Feb 27, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem:
apiMiddlewarereturns a promise for actions without a[CALL_API]property, this can lead to unexpected behaviour and nested promises.Solution:
Remove
asyncfrom returnedactionfunction and return instead an async function afterisRSAAvalidation.