feat: add the zig_shared_library rule to generate shared objects or dynamic libraries #103
Conversation
There was a problem hiding this comment.
Thank you, that's already looking great! You're close.
One small comment (some test definitions are missing).
I'm not sure what command to run for the cross-platform tests. @aherrmann please advise.
These tests are included in the standard test suites. So, they'll run when you run bazel test //.... To run these tests specifically you can use the command bazel test //zig/tests:target_platform_test. (The tests use Bazel's transitions system under the hood to test different target platforms.)
Titousensei
force-pushed
the
shared_lib
branch
2 times, most recently
from
5cc8a1e to
14f0c84
Compare
|
Updated to fix the tests and address the comments:
|
Titousensei
force-pushed
the
shared_lib
branch
from
14f0c84 to
6122710
Compare
|
Fixed tests failures related to defs import |
``` ./zig/private/common/zig_build.bzl:206: uninitialized: Variable "dynamic" may not have been initialized. (https://github.com/bazelbuild/buildtools/blob/master/WARNINGS.md#uninitialized) ```
The 'lib' prefix was not taken into account.
There was a problem hiding this comment.
Thank you for contributing this feature!
I fixed a few more minor issues. I also noticed that there was a typo in the docs, these docs are automatically generated by running bazel run //docs:update, or by bazel run //utils:update which also updates other generated files.
aherrmann
changed the title
Solves #102
This is what I have so far. I'm not sure what command to run for the cross-platform tests. @aherrmann please advise.