feat: remove zig_runfiles in favor of bazel_builtin #212
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replace zig_runfiles by bazel_builtin to determine current_repository.
At this point the zig_runfiles rule was only used to provide the current repository name for runfiles lookup. This can now be done using the implicit bazel_builtin package instead. In future we may want to implement a zig_runfiles rule similar to what is provided by https://github.com/fmeum/rules_runfiles. However, rules_runfiles may be the better home for such a rule.
aherrmann
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on #211
Part of #86
At this point the zig_runfiles rule was only used to provide the current repository name for runfiles lookup. This can now be done using the implicit bazel_builtin package instead.
In future we may want to implement a zig_runfiles rule similar to what is provided by https://github.com/fmeum/rules_runfiles. However, rules_runfiles may be the better home for such a rule.