feat!: support multiple Zig SDK versions #258
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Toolchains are selected via toolchain resolution. The name of the repository is irrelevant in this context. A better approach is to support registering multiple versions and using constraints to let the user pick between different versions. BREAKING CHANGE: The zig module extension no longer accepts a name attr.
The name attribute is no longer used
For backward compatibility
This allows a user to select among multiple different Zig SDK versions via build flags or transitions and to select based on the Zig SDK version or configure target compatibility with a specific version.
Toolchain resolution proceeds in the order in which toolchains are registered. When toolchains are registered through a wildcard label, such as `:all`, then their order is determined by lexicographical order. Add numerical prefixes to ensure that the user defined order is respected.
This reverts commit 1128655.
This reverts commit 454867c.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #257
Support the registration and selection between multiple different Zig SDK versions.
Users can register multiple Zig SDK versions using the
zigmodule extension orzig_register_toolchainsrepository rule. Toolchains will be defined and registered for all specified versions. A specific toolchain version can be selected using the--@zig_toolchains//:versionbuild flag.BREAKING CHANGE: The zig module extension no longer accepts a name attr.