Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Yannick to contributors #108

Merged
merged 1 commit into from
Feb 9, 2022
Merged

Add Yannick to contributors #108

merged 1 commit into from
Feb 9, 2022

Conversation

mcgibbon
Copy link
Collaborator

@mcgibbon mcgibbon commented Feb 9, 2022

Purpose

When merging Yannick's changes for enabling different number of ranks on tile edges/corners, we didn't add him to the CONTRIBUTORS.md. This PR does so.

Checklist

Before submitting this PR, please make sure:

  • You have followed the coding standards guidelines established at Code Review Checklist.
  • Docstrings and type hints are added to new and updated routines, as appropriate
  • All relevant documentation has been updated or added (e.g. README, CONTRIBUTING docs)
  • For each public change and fix in pace-util, HISTORY has been updated
  • Unit tests are added or updated for non-stencil code changes

Additionally, if this PR contains code authored by new contributors:

  • The names of all the new contributors have been added to CONTRIBUTORS.md

@mcgibbon mcgibbon requested a review from twicki February 9, 2022 00:14
@mcgibbon mcgibbon enabled auto-merge (squash) February 9, 2022 00:14
@elynnwu
Copy link
Collaborator

elynnwu commented Feb 9, 2022

It would be nice if we don't have to run all tests for a change like this...

@mcgibbon
Copy link
Collaborator Author

mcgibbon commented Feb 9, 2022

launch jenkins

@mcgibbon mcgibbon merged commit 04274f0 into main Feb 9, 2022
@mcgibbon mcgibbon deleted the feature/update_contributors branch February 9, 2022 18:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants