Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/plotting tools #13

Merged
merged 10 commits into from
Nov 9, 2021
Merged

Feature/plotting tools #13

merged 10 commits into from
Nov 9, 2021

Conversation

FlorianDeconinck
Copy link
Contributor

Standing cli script
Example to run Pace on daint.
Plotting tools

@elynnwu
Copy link
Collaborator

elynnwu commented Nov 8, 2021

launch jenkins

Copy link
Collaborator

@elynnwu elynnwu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for polishing the plotting tools!


# Reuse infrastructure to read in grid variables
# add path to integration test to reuse existing grid logic
sys.path.append(
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[OPTIONAL] This is the daint path you had, I realized that I also had it hard coded to the path in the docker container. Should we have an environment flag IS_DOCKER to switch between the two? Or maybe relative to this path?

I realize that this will be eliminated fairly soon so probably not worth it.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am going to pass on refactoring this, because it'll be gone soon and because I think this script will be use on daint mostly to get the data you want quickly (and on all arch)

@@ -0,0 +1,12 @@
from PIL import Image
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since we said in Readme that we don't include plotting requirement, this is probably okay. But is this package in the fv3viz environment?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No it's not, it's more a small utility to make gif from the command line

@FlorianDeconinck FlorianDeconinck merged commit bce9a3f into main Nov 9, 2021
@FlorianDeconinck FlorianDeconinck deleted the feature/plotting_tools branch November 9, 2021 21:59
FlorianDeconinck pushed a commit to gronerl/pace that referenced this pull request Jul 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants