Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix grid tests for 54 ranks #17

Merged
merged 6 commits into from
Nov 19, 2021
Merged

fix grid tests for 54 ranks #17

merged 6 commits into from
Nov 19, 2021

Conversation

rheacangeo
Copy link
Contributor

@rheacangeo rheacangeo commented Nov 16, 2021

Purpose

To have the regressions-cron test in CI passing, specifically getting the new grid tests to work for c12_54ranks_standard.

  • GnomonicGrid and MirrorGrid tests run on the global tile and are changed to be done with. numpy only (no quantities needed).

…est as the reason for failure on c48_6ranks needs more investigation. Adding overrides for grid tests that need looser bounds for c48. c48 data for GridAreas is broken
@rheacangeo rheacangeo requested a review from oelbert November 16, 2021 16:45
@rheacangeo
Copy link
Contributor Author

Closing this for now, as @oelbert pointed out, some of these threshold shifts are worrying and warrant a fuller investigation. Plus the fortran data generation is broken. We'll open a new PR when we get this sorted.

@rheacangeo rheacangeo closed this Nov 16, 2021
@rheacangeo rheacangeo reopened this Nov 16, 2021
@rheacangeo
Copy link
Contributor Author

Turning the PR back on to at least fix the 54 rank tests

@rheacangeo rheacangeo changed the title fix grid tests for c48 and 54 ranks fix grid tests for 54 ranks Nov 16, 2021
Copy link
Contributor

@oelbert oelbert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@rheacangeo rheacangeo enabled auto-merge (squash) November 17, 2021 21:12
@rheacangeo
Copy link
Contributor Author

launch jenkins

@rheacangeo
Copy link
Contributor Author

launch jenkins

@rheacangeo
Copy link
Contributor Author

launch jenkins

@rheacangeo rheacangeo merged commit 2ed2e38 into main Nov 19, 2021
@rheacangeo rheacangeo deleted the bugfix/cron-regressions branch November 19, 2021 20:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants