Enable tests for fv3core infrastructure code on CircleCI #23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mcgibbon
changed the title
elynnwu
reviewed
Nov 18, 2021
| pytest-subtests | ||
| pytest-cov | ||
| -e external/fv3gfs-util | ||
| git+https://github.com/ai2cm/gt4py.git@v36#egg=gt4py |
There was a problem hiding this comment.
Can you have the tag linked to the top level GT4PY_VERSION?
There was a problem hiding this comment.
if I can refactor the GT4PY_VERSION file to have git+https://github.com/ai2cm/gt4py.git@v36#egg=gt4py instead of v36 then yes, otherwise this is a bit harder to accomplish.
elynnwu
approved these changes
Nov 23, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds configuration to run the fv3core "main" tests on CircleCI. This should greatly reduce turn-around time for test failures in fv3core, particularly when developing infrastructure code whose tests are being run.