Skip to content

add physics and driver savepoint tests #328

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 17 commits into from
Sep 19, 2022

Conversation

elynnwu
Copy link
Collaborator

@elynnwu elynnwu commented Sep 16, 2022

Purpose

This PR adds physics and driver savepoint tests, Jenkins will only run dace gpu test.

Code changes:

  • translate_driver: increase max error for circleci test
  • build_and_push_image: we push docker image in circleci now
  • circle ci config: add physics serial and mpi savepoint test, add driver mpi savepoint test

Infrastructure changes:

  • circleci test now includes: dycore and physic serial and mpi savepoint (6 & 54 ranks), driver mpi savepoint (6 & 54 ranks)

Checklist

  • You have followed the coding standards guidelines established at Code Review Checklist.
  • Docstrings and type hints are added to new and updated routines, as appropriate
  • All relevant documentation has been updated or added (e.g. README, CONTRIBUTING docs)
  • For each public change and fix in pace-util, HISTORY has been updated
  • Unit tests are added or updated for non-stencil code changes

@elynnwu elynnwu marked this pull request as ready for review September 19, 2022 18:36
Copy link
Collaborator

@mcgibbon mcgibbon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@elynnwu elynnwu merged commit 75de30b into main Sep 19, 2022
@elynnwu elynnwu deleted the feature/add-circleci-physics-driver-test branch September 19, 2022 23:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants