Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add checkpointer tests to CircleCI #336

Merged
merged 53 commits into from
Oct 18, 2022
Merged

Conversation

mcgibbon
Copy link
Collaborator

@mcgibbon mcgibbon commented Sep 19, 2022

Purpose

This PR adds checkpointer tests to CircleCI, as a top-level "savepoint" test.

Code changes:

  • Added checkpointer calls to Remapping and TracerAdvection classes

Infrastructure changes:

  • increase resource class for driver_savepoints_mpi and test_mpi_54rank to xlarge
  • add test_savepoint CircleCI plan which runs top-level savepoint tests, currently only checkpointer tests
  • add test_savepoint top-level makefile target (in contrast to savepoint_tests target, which is really the dycore tests only)

Checklist

Before submitting this PR, please make sure:

  • You have followed the coding standards guidelines established at Code Review Checklist.
  • Docstrings and type hints are added to new and updated routines, as appropriate
  • All relevant documentation has been updated or added (e.g. README, CONTRIBUTING docs)
  • For each public change and fix in pace-util, HISTORY has been updated
  • Unit tests are added or updated for non-stencil code changes

@mcgibbon mcgibbon changed the base branch from main to fix/checkpointer-validation September 19, 2022 23:59
@mcgibbon mcgibbon changed the base branch from fix/checkpointer-validation to main September 20, 2022 15:53
@mcgibbon mcgibbon marked this pull request as ready for review September 20, 2022 22:56
@mcgibbon mcgibbon enabled auto-merge (squash) October 18, 2022 21:48
@mcgibbon mcgibbon merged commit 126b1ba into main Oct 18, 2022
@mcgibbon mcgibbon deleted the feature/checkpointer_circleci branch October 18, 2022 22:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants