Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix microphysics issue for non-orchestrated GPU backend #340

Merged
merged 4 commits into from
Sep 21, 2022

Conversation

elynnwu
Copy link
Collaborator

@elynnwu elynnwu commented Sep 20, 2022

Purpose

This PR fixes #257.

Code changes:

  • microphysics.py: use cp only in orchestrated mode, regular gpu backend needs to be numpy because we cannot direct index cupy array

Infrastructure changes:

  • Physics dace:gpu savepoint tests are now enabled on daint, all other backends are not tested through jenkins anymore since they are tested as part of circleci.

Checklist

  • You have followed the coding standards guidelines established at Code Review Checklist.
  • Docstrings and type hints are added to new and updated routines, as appropriate
  • All relevant documentation has been updated or added (e.g. README, CONTRIBUTING docs)
  • For each public change and fix in pace-util, HISTORY has been updated
  • Unit tests are added or updated for non-stencil code changes

Sorry, something went wrong.

@elynnwu
Copy link
Collaborator Author

elynnwu commented Sep 21, 2022

launch jenkins

Comment on lines +1909 to +1910
# In orchestration mode, we pass the device memory
# TODO: turn arrays in setupm into a dataclass, or inidivudal scalars
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
# In orchestration mode, we pass the device memory
# TODO: turn arrays in setupm into a dataclass, or inidivudal scalars
# In orchestration mode, we pass the device memory
# TODO: turn arrays in setupm into a dataclass, or individual scalars

Copy link
Contributor

@jdahm jdahm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch!

@elynnwu elynnwu merged commit 9b8b3c8 into main Sep 21, 2022
@elynnwu elynnwu deleted the fix/microphysics-gpu branch September 21, 2022 18:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Direct indexing of arrays in microphysics
2 participants