Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix physics storage bug #349

Merged
merged 2 commits into from
Oct 4, 2022
Merged

Fix physics storage bug #349

merged 2 commits into from
Oct 4, 2022

Conversation

elynnwu
Copy link
Collaborator

@elynnwu elynnwu commented Oct 4, 2022

Purpose

Physics state phii and tendency variables need to be reset to zero in between steps. These variables are first used as read before writing, so they need to be reset back to zero.

Code changes:

  • physics: set phii and *_dt to zero first

Checklist

Before submitting this PR, please make sure:

  • You have followed the coding standards guidelines established at Code Review Checklist.
  • Docstrings and type hints are added to new and updated routines, as appropriate
  • All relevant documentation has been updated or added (e.g. README, CONTRIBUTING docs)
  • For each public change and fix in pace-util, HISTORY has been updated
  • Unit tests are added or updated for non-stencil code changes

Copy link
Contributor

@twicki twicki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great find, this is awesome

@twicki twicki merged commit 24421ed into main Oct 4, 2022
@twicki twicki deleted the fix/reset-storage-to-zero branch October 4, 2022 08:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants