Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add week of year to gt_cache circleci cache key #359

Merged
merged 4 commits into from
Oct 28, 2022

Conversation

mcgibbon
Copy link
Collaborator

@mcgibbon mcgibbon commented Oct 18, 2022

Purpose

Caching of gt4py caches on CircleCI currently only invalidates the cache if the gt4py version changes. However, caches become unusable as soon as code changes.

This PR updates the caching so that caches invalidate weekly. This should ensure that caches are at least valid on main at the start of the week, and speed up test execution, at the cost of needing to rebuild the caches at the start of the week.

Infrastructure changes:

  • Updated CircleCI gt4py cache caching so that caches invalidate weekly

Checklist

Before submitting this PR, please make sure:

  • You have followed the coding standards guidelines established at Code Review Checklist.
  • Docstrings and type hints are added to new and updated routines, as appropriate
  • All relevant documentation has been updated or added (e.g. README, CONTRIBUTING docs)
  • For each public change and fix in pace-util, HISTORY has been updated

@mcgibbon mcgibbon added the inactive This PR is not currently being worked on label Oct 19, 2022
@mcgibbon
Copy link
Collaborator Author

Didn't improve test time by much because it turns out we aren't changing the computational code much right now. May merge later when we continue refactoring computational code.

@elynnwu elynnwu merged commit 341adfe into main Oct 28, 2022
@elynnwu elynnwu deleted the feature/circleci_weekly_cache branch October 28, 2022 18:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
inactive This PR is not currently being worked on
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants