-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/diagnostics level select #370
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just a few questions
@@ -33,6 +33,10 @@ diagnostics_config: | |||
- qrain | |||
- qsnow | |||
- qgraupel | |||
z_select: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did we decide to re-think the layout in the config in a later PR? Or did you and @mcgibbon come to this as the final look?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We converged to this layout because it is saved as a separate variable instead of as part of the snapshot.
driver/pace/driver/diagnostics.py
Outdated
level: int | ||
names: List[str] | ||
|
||
def slice_data(self, state: DycoreState): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
technically we select and don't slice here - not super relevant as selecting is a 1-sized slice, but if we actually wan to implement both we might want to rename it here already?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changed it to select data.
Purpose
This PR adds the capability of saving a vertical slice using
z_select
in the diagnostics config.The expected syntax is as follows:
Code changes:
ZSelect
class for storing selected vertical slice and the variables to be saved1/gravity
Checklist
Before submitting this PR, please make sure:
pace-util
, HISTORY has been updated