Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Save one file per tile in NetCDFMonitor #376

Merged
merged 4 commits into from
Nov 8, 2022
Merged

Save one file per tile in NetCDFMonitor #376

merged 4 commits into from
Nov 8, 2022

Conversation

mcgibbon
Copy link
Collaborator

@mcgibbon mcgibbon commented Nov 7, 2022 •
edited
Loading

Purpose

This PR refactors NetCDFMonitor so that it saves one file per tile.

Code changes:

  • NetCDFMonitor now saves one file per tile, instead of one file globally.

Checklist

Before submitting this PR, please make sure:

  • You have followed the coding standards guidelines established at Code Review Checklist.
  • Docstrings and type hints are added to new and updated routines, as appropriate
  • All relevant documentation has been updated or added (e.g. README, CONTRIBUTING docs)
  • For each public change and fix in pace-util, HISTORY has been updated
  • Unit tests are added or updated for non-stencil code changes

@mcgibbon mcgibbon changed the title Save one file per tile in netcdf monitor Save one file per tile in NetCDFMonitor Nov 7, 2022
@mcgibbon mcgibbon requested a review from elynnwu November 7, 2022 20:42
elynnwu
elynnwu reviewed Nov 7, 2022
View reviewed changes
util/pace/util/local_comm.py Outdated
Comment on lines 28 to 31
class SplitState(Enum):
NO_SPLIT = 0
SPLITTING = 1
ALREADY_SPLIT = 2
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't understand why we need this if only no split is used?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Vestigial code. Deleted.

@mcgibbon mcgibbon enabled auto-merge (squash) November 7, 2022 22:24
@mcgibbon mcgibbon merged commit 97018f2 into main Nov 8, 2022
@mcgibbon mcgibbon deleted the feature/tile_netcdf_monitor branch November 8, 2022 00:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@elynnwu elynnwu elynnwu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mcgibbon @elynnwu