Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename fv3gfs-util to pace-util #43

Merged
merged 5 commits into from
Dec 3, 2021
Merged

Rename fv3gfs-util to pace-util #43

merged 5 commits into from
Dec 3, 2021

Conversation

mcgibbon
Copy link
Collaborator

@mcgibbon mcgibbon commented Dec 3, 2021

We've decided to rename the fv3gfs namespace to pace. This PR renames fv3gfs.util to pace.util.

Changes:

  • fv3gfs-util and fv3gfs.util are changed to pace-util and pace.util
  • added .dockerignore at the top level
  • removed update_submodules_base make target from fv3core, since the submodule it updates no longer exists

Base automatically changed from feature/enable_util_flake8 to main December 3, 2021 00:17
elynnwu
elynnwu approved these changes Dec 3, 2021
View reviewed changes
Copy link
Collaborator

@elynnwu elynnwu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Glad we chose the name pace, everything is more compact now!

fv3core/Makefile
@@ -16,7 +16,7 @@ CONTAINER_ENGINE ?=docker
RUN_FLAGS ?=--rm
TEST_ARGS ?=
TEST_DATA_HOST ?=$(CWD)/test_data/$(EXPERIMENT)
FV3UTIL_DIR=$(CWD)/external/fv3gfs-util
FV3UTIL_DIR=$(CWD)/external/pace-util
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[optional] Should we change this too?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are a bunch of references to fv3util too when doing import pace.util as fv3util. Not sure what we want to do with these.

@mcgibbon
Copy link
Collaborator Author

mcgibbon commented Dec 3, 2021

Tests are failing due to fv3gfs-util still being used in jenkins config, will update it today hopefully in a way that doesn't break PRs.

@mcgibbon
Copy link
Collaborator Author

mcgibbon commented Dec 3, 2021

launch jenkins

@mcgibbon mcgibbon merged commit e624ad7 into main Dec 3, 2021
@mcgibbon mcgibbon deleted the feature/rename_pace_util branch December 3, 2021 20:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@elynnwu elynnwu elynnwu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mcgibbon @elynnwu