Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consolidate daint logic into buildenv (env vars) and daint_venv (python packages) #54

Merged
merged 7 commits into from
Dec 17, 2021
Merged

Consolidate daint logic into buildenv (env vars) and daint_venv (python packages) #54

merged 7 commits into from
Dec 17, 2021

Conversation

mcgibbon
Copy link
Collaborator

@mcgibbon mcgibbon commented Dec 8, 2021 •
edited
Loading

Moved the following to buildenv:

  • setting MPICH_RDMA_ENABLED_CUDA and CUDA_CRAY_MPS environment variables
  • setting PYTHONPATH to include serialbox
  • loading daint-gpu and gcloud modules

Depends on ai2cm/buildenv#30

@mcgibbon mcgibbon marked this pull request as ready for review December 14, 2021 18:34
@mcgibbon mcgibbon requested a review from twicki December 14, 2021 22:04
twicki
twicki reviewed Dec 16, 2021
View reviewed changes
Copy link
Contributor

@twicki twicki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mcgibbon mcgibbon enabled auto-merge (squash) December 17, 2021 17:56
@mcgibbon mcgibbon merged commit 63b3f36 into main Dec 17, 2021
@mcgibbon mcgibbon deleted the feature/consolidate_daint_venv branch December 17, 2021 19:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@twicki twicki twicki approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mcgibbon @twicki