Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

create template again #72

Merged
merged 3 commits into from
Dec 17, 2021
Merged

create template again #72

merged 3 commits into from
Dec 17, 2021

Conversation

twicki
Copy link
Contributor

@twicki twicki commented Dec 17, 2021

we don't have the template from fv3core moved over - this pr does it

@twicki twicki requested a review from elynnwu December 17, 2021 00:32
elynnwu
elynnwu reviewed Dec 17, 2021
View reviewed changes
Copy link
Collaborator

@elynnwu elynnwu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you have a leftover buildenv that got into this PR

tobias added 2 commits December 16, 2021 16:40
elynnwu
elynnwu approved these changes Dec 17, 2021
View reviewed changes
Copy link
Collaborator

@elynnwu elynnwu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@twicki twicki merged commit f19a029 into main Dec 17, 2021
@twicki twicki deleted the setup_template branch December 17, 2021 16:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@elynnwu elynnwu elynnwu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@twicki @elynnwu