Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor DycoreState initialization routines to use only GridSizer when possible #92

Merged
merged 15 commits into from
Jan 7, 2022
Merged

refactor DycoreState initialization routines to use only GridSizer when possible #92

merged 15 commits into from
Jan 7, 2022

Conversation

mcgibbon
Copy link
Collaborator

@mcgibbon mcgibbon commented Jan 5, 2022 •
edited
Loading

Purpose

Some factory class methods on DycoreState took in QuantityFactory when they only need a GridSizer, and do their own manual quantity initialization. This PR refactors those call signatures to take in the more minimal GridSizer class.

Code changes:

  • Refactored DycoreState.init_from_storages and DycoreState.init_from_numpy_arrays to take in a GridSizer instead of a QuantityFactory

Checklist

Before submitting this PR, please make sure:

  • You have followed the coding standards guidelines established at Code Review Checklist.
  • Docstrings and type hints are added to new and updated routines, as appropriate
  • All relevant documentation has been updated or added (e.g. README, CONTRIBUTING docs)
  • For each public change and fix in pace-util, HISTORY has been updated
  • Unit tests are added or updated for non-stencil code changes

@mcgibbon
refactor DycoreState to use quantity attributes instead of storage
47d1f5c
@mcgibbon
restore pace-util as a symlink
4c4b7aa
@mcgibbon
Merge branch 'main' into feature/dycore_quantity
0f44ad0
@mcgibbon
move pace-util symlink to correct location
b3144f7
@mcgibbon
Merge branch 'main' into feature/dycore_quantity
84ec6bb
@mcgibbon
remove unused from_dycore_state method
b1c4f52
@mcgibbon
response to reviewer comments
37d88cb
@mcgibbon
response to reviewer comments
9e13b89
@mcgibbon
remove newly added get_ methods on QuantityFactory
27f08dd
@mcgibbon
really delete the methods this time
0fc97af
@mcgibbon
Merge branch 'feature/dycore_quantity' into feature/minimize_dycore_s…
fbb9670 
…tate_init_signature
@mcgibbon
refactor DycoreState initialization routines to use only GridSizer wh…
ebd6061 
…ere possible
@mcgibbon
Merge branch 'main' into feature/dycore_quantity
710e4e8
@mcgibbon
Merge branch 'feature/dycore_quantity' into feature/minimize_dycore_s…
de38dd7 
…tate_init_signature
Base automatically changed from feature/dycore_quantity to main January 6, 2022 00:06
@mcgibbon mcgibbon requested a review from elynnwu January 6, 2022 00:10
elynnwu
elynnwu approved these changes Jan 7, 2022
View reviewed changes
Copy link
Collaborator

@elynnwu elynnwu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@mcgibbon mcgibbon merged commit cb48188 into main Jan 7, 2022
@mcgibbon mcgibbon deleted the feature/minimize_dycore_state_init_signature branch January 7, 2022 18:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@elynnwu elynnwu elynnwu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mcgibbon @elynnwu