Skip to content

issue992 #246

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 26 commits into
base: main
Choose a base branch
from
Draft

issue992 #246

wants to merge 26 commits into from

Conversation

ClemensBuechner
Copy link
Contributor

No description provided.

@remochristen remochristen force-pushed the issue992 branch 3 times, most recently from a088dc1 to 4982fc3 Compare February 7, 2025 14:47
@ClemensBuechner ClemensBuechner force-pushed the issue992 branch 3 times, most recently from a5ea42f to c724ad5 Compare February 11, 2025 14:05
SimonDold
SimonDold reviewed Feb 11, 2025
View reviewed changes
Copy link
Contributor

@SimonDold SimonDold left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left a few comments, nothing big.
The biggest surprise to me was that the landmarkgraph is now treated as an iterable with the begin and end function (which is an indirection to the begin and end function of the nodes filed).

LGTM overall.

And it got a lot more pleasant to read, especially the parts that used single letter variable names :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SimonDold SimonDold SimonDold left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ClemensBuechner @SimonDold @remochristen