Decode 'htmlsrc' to string before re.sub() #13
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Python 3 has distinct types for a byte array and a string, and requires explicit conversion between them. In order to make the script to work with Python 3, decode 'htmlsrc' to string before applying using the re.sub() API. Before writing the attachment to a file, encode it back to as a byte array. Signed-off-by: Jarkko Sakkinen <jarkko.sakkinen@iki.fi>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Python 3 has a distinct types for a byte array and a string, and
requires explicit conversion between them. In order to make the script
to work with Python 3, decode 'htmlsrc' to string before applying the
re.sub() API. Before writing the attachment to a file, encode it back to
as a byte array.
Signed-off-by: Jarkko Sakkinen jarkko.sakkinen@iki.fi