Don't decode messages before substitution #22
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When decoding the message from bytes to an UTF-8 string and replacing characters that couldn't be decoded - characters from some encodings will be lost when encoding it to bytes again, do the regex on the byte data instead. Also make sure all three different input methods (Maildir, File and stdin) use BytesParser as introduced in 5db80f1.
hjerning
force-pushed
the
message_from_bytes
branch
from
4ef6e38 to
d583189
Compare
|
First of all, thanks for this excellent tool! I have been using it since 2e84ba9. Your change last week to use The part to skip |
hjerning
changed the title
|
Thanks! I don't get that much mail with nonascii encodings (and what I do get is often encoded improperly, from people copy/pasting across different apps), so it's super helpful to get patches like this. And thanks for reminding me; I sometimes get swamped keeping track of emails and forget that I have an issue that I need to attend to. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Without this patch
I'm unable to openiso-8859-1 and iso-8859-15 encoded emails with åäö in them are garbled.Fixes #21.