Fix subsampling issues within StateArrayDataset
#12
+135
−123
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses issue #11 by bundling naive occs, posterior occs, and processed stats calculations. These are parallelized by file using
StateArrayDataset.parallel_map(). A pitfall to this approach is getting just the processed track statistics is now much slower for the user.Functionality changes:
clear()now deletesprocessed_track_statistics, since these must be calculated with occupancies. Added a test to catch this.calc_naive_occs()removed, as it's no longer needed.calc_marginal_naive_occs()removed, as it's no longer needed.calc_posterior_occs()bundled intocalc_marginal_posterior_occs(), no longer needed.naive occs were calculated incorrectly and was fixed now. The test for this was also incorrect and fixed now.
Minor changes:
_get_processed_track_statistics()removedLet me know what you think @alecheckert!