New config option to disable community index #933
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This way we can ensure that no test in our testsuite is inadvertently using the community index, as indeed it was happening.
src/alire/alire-config.ads
Outdated
| @@ -25,6 +25,10 @@ package Alire.Config with Preelaborate is | |||
|
|
|||
| Editor_Cmd : constant Config_Key := "editor.cmd"; | |||
|
|
|||
| Catalog_Autoconfig : constant Config_Key := "catalog.autoconfig"; | |||
There was a problem hiding this comment.
I don't find the name very meaningful. I would rather have something like catalog.auto_community.
Also do we use the word catalog a lot? I thought index was the right word here.
There was a problem hiding this comment.
I was trying to go for a catalog being the sum of all your configured indexes, but it's probably too confusing, yeah.
Fabien-Chouteau
approved these changes
Feb 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This way we can ensure that no test in our testsuite is inadvertently using the
community index, as indeed it was happening.