Fetch redirected urls #900
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
damianham
approved these changes
Jun 27, 2018
robacarp
approved these changes
Jun 27, 2018
drujensen
approved these changes
Jul 2, 2018
|
This works but is pretty hacky, What would happens if the URL redirects 3 or more times? I think we need something like |
|
There's an open issue for that in the stdlib. Someone just has to implement it (and it needs to be discussed how to implement it, which will probably result in it becoming a monster of complexity) |
|
@faustinoaq should we merge this or should this wait? |
|
Closing this. Recipes will no longer be hosted by Amber. We will work on allowing a recipe to be provided by a shard in a git repository. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the Change
This PR adds the ability to fetch redirected urls like the used on recipes release page
Alternate Designs
Use redirect option on
HTTP::Client(not supported yet, see: crystal-lang/crystal#2721)Benefits
Fixes #899
Possible Drawbacks
No